Trigger error on custom class #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-lint-apply-err-to-custom-classname.surge.sh |
|
Size Change: +2 B (0%) Total Size: 441 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
a389a96
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df62706e.orbit.pages.dev |
| Branch Preview URL: | https://lint-apply-err-to-custom-cla.orbit.pages.dev |
|
The second commit reads: However, I don't see any replacement of a warn rule, it's essentially adding a new rule. |
|
@mvidalgarcia On our root eslint config, we have it defined as a warn. On the orbit-components package, I override that definition to be an error (on that package only). This way we can keep the warning on the other packages but we have a failing pipeline on the orbit-components package. WDYT? |
| @@ -31,6 +31,7 @@ module.exports = { | |||
| files: ["src/**/*.ts?(x)"], | |||
| rules: { | |||
| "@typescript-eslint/consistent-type-imports": "warn", | |||
| "tailwindcss/no-custom-classname": [2, { whitelist: ["(orbit\\-).*"] }], | |||
There was a problem hiding this comment.
As discussed offline, for readability.
Suggested change
| "tailwindcss/no-custom-classname": [2, { whitelist: ["(orbit\\-).*"] }], | |
| "tailwindcss/no-custom-classname": ["error", { whitelist: ["(orbit\\-).*"] }], |
Ok ok, I didn't know this. Perhaps we can add this information in the commit body. |
DSil
force-pushed
the
lint/apply-err-to-custom-classname
branch
2 times, most recently
from
89d4641 to
e0c25f6
Compare
DSil
force-pushed
the
lint/apply-err-to-custom-classname
branch
from
098a486 to
7a15c97
Compare
Only changing the rule for orbit-components package. The root eslint config remains as a warning, for other packages.
DSil
force-pushed
the
lint/apply-err-to-custom-classname
branch
from
7a15c97 to
a389a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions for typescript-lint and es-lint deps and change from warning to error the no-custom-classname rule for tailwind.
The new rule is only applied on orbit-components, so it does not affect the docs package or any other package.
FEPLT-1760