-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ButtonPrimitive): width prop now works as expected #4199
Conversation
Deploying with Cloudflare Pages
|
Size Change: +3 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
8911e40
to
95ef3ff
Compare
@DSil LGTM :) seems like just snapshots needed to be updated |
I can't update snapshots. I am still unable to execute playwright locally |
Hm, can you describe? maybe I can help. Meanwhile, I can update them in this branch, if you do not mind :) |
@mainframev it's an old issue when the visual tests were introduced, I was never able to run them. It fails on installing the deps and then it fails on the test script. Please update the snapshots yourself on this branch |
9232b3d
to
12fe156
Compare
12fe156
to
0e00073
Compare
Width prop now works as expected on ButtonPrimitive.
On the Stepper example, it may still not be 44px but that's because it's missing
flex: none
, added in #4196.Also adjusted the
justify-content
styles, that were off.FEPLT-1843
Storybook: https://orbit-mainframev-fix-width-button-primitive.surge.sh