-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Popover): remove redundant max-w-fit class #4185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: -33 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
mainframev
force-pushed
the
fix/popover-issues-reported
branch
from
December 7, 2023 22:35
92ab07e
to
695cb06
Compare
DSil
approved these changes
Dec 11, 2023
DSil
force-pushed
the
fix/popover-issues-reported
branch
from
December 11, 2023 10:04
695cb06
to
65b503d
Compare
mainframev
force-pushed
the
fix/popover-issues-reported
branch
from
December 11, 2023 14:04
65b503d
to
d9fcff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here. It wasn't present in the component before and caused bug, so I think better will be to remove
max-w-fit
.Storybook: https://orbit-mainframev-fix-popover-issues-reported.surge.sh
Giving solution to FEPLT-1865