-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "smallMobile" of the Hide component hide stuff on screens of size 0-320px #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +2 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
@jozef-mikusinec-kiwicom tbh I don't think it's a big issue, as unlikely there are screens like 200px, but thanks for contribution and it will be more correct now 👍🏻 |
@jozef-mikusinec-kiwicom just update the snapshots and it's good |
jozef-mikusinec-kiwicom
force-pushed
the
jozef/hide-small-mobile
branch
from
December 7, 2023 08:02
c0246df
to
26cfbd9
Compare
@mainframev snapshots updated |
mainframev
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"smallMobile" is the smallest screen size that Orbit recognizes. It ought to hide everything for screens of size 0px - 413px.
The alternative would be to add a new screen size smaller than "smallMobile".
Also removes deprecated components Desktop and Mobile from docs
Storybook: https://orbit-mainframev-jozef-hide-small-mobile.surge.sh