-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Popover): links inside tooltips inside content are now clickable #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: +4 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
DSil
force-pushed
the
fix/clik-outside-popup-with-link
branch
2 times, most recently
from
December 1, 2023 13:13
d021c47
to
bb3fb03
Compare
@DSil can this behaviour be covered by a simple unit test? 🙏🏻 eg
|
DSil
force-pushed
the
fix/clik-outside-popup-with-link
branch
from
December 1, 2023 14:15
bb3fb03
to
4f39c4a
Compare
mainframev
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outside click hook was triggering the close before the event was captured by interactable components. This was changed just for the Popover, so no breaking behavior should occur.
FEPLT-1841
Storybook: https://orbit-mainframev-fix-clik-outside-popup-with-link.surge.sh