fix(Stack): remove height: 100% for justify and column #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -20 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
db6093c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8114a0a0.orbit.pages.dev |
| Branch Preview URL: | https://fix-stack-height.orbit.pages.dev |
mainframev
force-pushed
the
fix/stack-height
branch
from
7097521 to
499516f
Compare
mainframev
force-pushed
the
fix/stack-height
branch
from
499516f to
db6093c
Compare
|
@DSil I will merge it to fix the broken documentation pages and our components. Basically, here it's the previous state of Stack, including the fix, just removed that idea of having 100% height, as described in the description of the PR. I apologize for merging without approve, just for the sake of not having broken docs. And it's just roll back to the previous state which was ok, so I do not think it needs code review, we may discuss later if this behaviour of justify requires our attention 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for that mess. I just rethought it again, while it was a change to have expected behavior with a direction column and justify and height, it may lead to visual breaking changes as in our docs, where
justifywas added with a column (but it was not doing anything) and got broken after this change. I think better would be better not to touch it right now, as it's already quite a lot of changes for users. At least we never received any request about this, so maybe it's not needed for users 🤷🏻Storybook: https://orbit-mainframev-fix-stack-height.surge.sh