fix(Stack): do not apply flex сlasses, when not needed #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
commented
Nov 22, 2023
| flex || inline ? getDisplayClasses(inline ? "inline-flex" : "flex", viewport) : "block", | ||
| getSpacingClasses(spacing, viewport, direction, legacy), | ||
| inline === false && "w-full", | ||
| inline === false && direction === DIRECTION.COLUMN && "h-full", |
There was a problem hiding this comment.
We have a prop called justify that is justify-content in flex-box, it works as expected with direction='row' (in case it’s not inlined with inline prop), but not with direction='column'
for instance, I expected it to be at the end with justify='end', but it’s placed in the beginning, the same goes for other values: around, between, and so on. To work as expected, the Stack div container should have a height: 100%, the same as with the row case, when it has a width: 100% (I think we should look at it as x and y axes and it should have 100% for justify prop)
I think we are missing it 🤔
There was a problem hiding this comment.
So you suggest that we automatically apply width=100% when direction=row and height=100% when direction=column?
There was a problem hiding this comment.
yes, the width is already applied, when it has no inline, which makes sense, the same is for height, we may add additional condition to apply it only when justify is provided 🤔
|
Size Change: +34 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
07f94d1
|
| Status: | ⚡️ Build in progress... |
mainframev
force-pushed
the
fix/stack-issue
branch
from
9f6ce15 to
9059903
Compare
mainframev
changed the title
mainframev
force-pushed
the
fix/stack-issue
branch
from
9059903 to
73fd914
Compare
DSil
approved these changes
Nov 23, 2023
DSil
force-pushed
the
fix/stack-issue
branch
from
73fd914 to
07f94d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving solution to FEPLT-1833
While working on fixing the flex styles issues, I also found an interesting behavior, I'd say unexpected, described below in the PR.
Storybook: https://orbit-mainframev-fix-stack-issue.surge.sh