-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix InputField and Radio #4160
Fix InputField and Radio #4160
Conversation
Size Change: -3 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
bf09799
to
1ec1d27
Compare
9e91bba
to
cd0635f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not in favor of the last two commits belonging to this PR, but I won't block because of that. Just one minor suggestion
disabled && "bg-form-element-disabled-background border-transparent", | ||
!disabled && "bg-form-element-background", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't it be?
disabled && "bg-form-element-disabled-background border-transparent", | |
!disabled && "bg-form-element-background", | |
disabled ? "bg-form-element-disabled-background border-transparent" : "bg-form-element-background" |
cd0635f
to
5b344ba
Compare
5b344ba
to
65f21b5
Compare
65f21b5
to
0c30eb9
Compare
https://kiwicom.atlassian.net/browse/FEPLT-1830
Storybook: https://orbit-mainframev-oreqizer-fix-form-things.surge.sh
I recommend going commit-by-commit as I
after both components were fixed, I generated correct Linux screenshots (and created a convenience
pancake.json
task)has one unrelated commit that decreases the pixel contrast threshold for it to count as a difference. it was causing false negatives when regenerating screenshots also in this MR so I added it here