fix(Hide): use native tailwind breakpoint range classes #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +9 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
5c1dfe1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://477093de.orbit.pages.dev |
| Branch Preview URL: | https://fix-hide-and-screens-issue.orbit.pages.dev |
DSil
requested changes
Nov 15, 2023
Comment on lines
-93
to
-95
| "sm-lm": { | ||
| max: px(tokens.breakpointLargeMobile - 1), | ||
| }, |
There was a problem hiding this comment.
This is being used in ModalFooter.
There was a problem hiding this comment.
good catch, thanks
| @@ -8,7 +8,7 @@ describe("Desktop", () => { | |||
| render(<Desktop>kek</Desktop>); | |||
| expect(screen.getByText("kek")).toMatchInlineSnapshot(` | |||
| <div | |||
| class="inline-block sm-mm:hidden mm-lm:hidden lm-tb:hidden tb-de:hidden" | |||
| class="inline-block sm:max-lm:hidden mm:max-lm:hidden lm:max-tb:hidden tb:max-de:hidden" | |||
There was a problem hiding this comment.
If we had sm-mm why did it change to sm:max-lm?
There was a problem hiding this comment.
it's inside Hide, will fix
| "lm-tb:hidden": on.includes("largeMobile"), | ||
| "tb-de:hidden": on.includes("tablet"), | ||
| "de-ld:hidden": on.includes("desktop"), | ||
| "sm:max-lm:hidden": on.includes("smallMobile"), |
There was a problem hiding this comment.
Shouldn't it be?
Suggested change
| "sm:max-lm:hidden": on.includes("smallMobile"), | |
| "sm:max-mm:hidden": on.includes("smallMobile"), |
| @@ -12,7 +12,7 @@ describe("Hide", () => { | |||
| ); | |||
| expect(container.childNodes[1]).toMatchInlineSnapshot(` | |||
| <div | |||
| class="inline-block sm-mm:hidden lm-tb:hidden ld:hidden" | |||
| class="inline-block sm:max-lm:hidden lm:max-tb:hidden ld:hidden" | |||
DSil
reviewed
Nov 20, 2023
mainframev
force-pushed
the
fix/hide-and-screens-issue
branch
from
d95d89c to
5c1dfe1
Compare
DSil
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
Fixes reported issue FEPLT-1819
Storybook: https://orbit-mainframev-fix-hide-and-screens-issue.surge.sh