Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typography font typo #4139

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

hajnyon
Copy link

@hajnyon hajnyon commented Nov 8, 2023

Fix of a typo in typography docs.

@DSil DSil force-pushed the docs/typography-typo-fix branch from 468193f to 60f8e68 Compare November 16, 2023 08:55
@DSil
Copy link
Collaborator

DSil commented Nov 16, 2023

@hajnyon thank you for your contribution. Can you please reword the commit so that the scope is docs:... and not fix(docs):...?

@hajnyon hajnyon changed the title fix(docs): typography font typo docs: typography font typo Nov 16, 2023
Copy link
Collaborator

@DSil DSil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@hajnyon
Copy link
Author

hajnyon commented Nov 16, 2023

@hajnyon thank you for your contribution. Can you please reword the commit so that the scope is docs:... and not fix(docs):...?
@DSil
Hey, I didn't amend the commit, is it ok to just rename the PR?

@DSil
Copy link
Collaborator

DSil commented Nov 16, 2023

@hajnyon thank you for your contribution. Can you please reword the commit so that the scope is docs:... and not fix(docs):...?

Hey, I didn't amend the commit, is it ok to just rename the PR?

Oh 🤦‍♂️ my bad. No, please reword the commit @hajnyon

@hajnyon hajnyon force-pushed the docs/typography-typo-fix branch from 60f8e68 to 5e80b1e Compare November 16, 2023 09:10
@hajnyon
Copy link
Author

hajnyon commented Nov 16, 2023

@DSil sorry, I wasn't quick enough (hadn't the repo locally, not sure if I can amend in GH) .. anyway, should be ready. Thanks for the merge :)

@DSil DSil merged commit d5deac6 into kiwicom:master Nov 16, 2023
10 of 13 checks passed
@hajnyon hajnyon deleted the docs/typography-typo-fix branch November 17, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants