Fix AttributeError on segmented button created in declarative python #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpianon
force-pushed
the
alpianon-patch-segmentedbutton
branch
from
3677f02 to
2adfc0d
Compare
In segmentedbutton.kv, we need to check if the MDSegmentButtonIcon object actually has a parent.parent before checking container's parent _label, otherwise you may get the following error: AttributeError: 'NoneType' object has no attribute 'parent' Fix kivymd#1735 Signed-off-by: Alberto Pianon <[email protected]>
alpianon
force-pushed
the
alpianon-patch-segmentedbutton
branch
from
2adfc0d to
9333959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
See #1735
Describe the algorithm of actions that leads to the problem
In segmentedbutton.kv, some code tries to access a MDSegmentedButtonIcon object parent's parent object without first checking if the MDSegmentedButtonIcon object actually has a parent's parent
Reproducing the problem
See #1735
Screenshots of the problem
See #1735
Description of Changes
In segmentedbutton.kv, we need to check if the MDSegmentButtonIcon object actually has a parent.parent before checking container's parent _label, otherwise you may get the following error: AttributeError: 'NoneType' object has no attribute 'parent'
Screenshots of the solution to the problem
Now the example code in #1735 works:
Code for testing new changes
The same example code found in #1735