Content providers #2200

pavelsof · 2020-05-14T22:06:40Z

This PR should make it possible to add content providers to the Android manifest. Two options are added to the common build.py script:

--content-providers is practically identical to the --intent-filters option, it expects the path to an XML file the contents of which are included in the AndroidManifest.xml.
--add-xml-resource can be used to copy one or more files over to the src/main/res/xml subdir of the build dir. This is needed because <provider> elements in the Android manifest usually have to refer to another XML file that defines the paths the app is allowed to "export".

If approved, I will also prepare a PR for the Buildozer repo to add the buildozer.spec counterparts.

pavelsof · 2020-05-21T13:41:43Z

Just opened kivy/buildozer#1119 as an example of how the two new build.py options could be used by Buildozer.

Please consider following up on either this PR here or on #1922, so that there is an easy way to setup content providers in a Kivy app.

AndreMiras · 2020-05-29T21:59:02Z

Thanks @pavelsof for the PR, looks clean.
I'm thinking, would it make sense to make the flag name more generic e.g. --extra-application-xml?
Because your application actually looks generic enough to cover other cases.
I'm wondering what @inclement thinks about it 🤔

inclement · 2020-05-30T12:00:56Z

pythonforandroid/bootstraps/service_only/build/templates/AndroidManifest.tmpl.xml

@@ -92,6 +92,10 @@
            </intent-filter>
        </receiver>
        {% endif %}
+
+        {%- if args.content_providers -%}


Why {%- rather than just {% (and same elsewhere)?

No other reason apart from not being familiar with Jinja and copy-pasting the lines that render the intent filters. I will fix it.

inclement · 2020-05-30T12:02:21Z

pythonforandroid/bootstraps/common/build/build.py

+                          'filename containing xml. The filename should be '
+                          'located relative to the python-for-android '
+                          'directory'))
+    ap.add_argument('--add-xml-resource', dest='add_xml_resource',


Didn't we add something else recently for moving stuff into the src/main/res folder?
I'm wondering if what we really want is a generic "copy this file/folder into src/main/res" argument, rather than many arguments for different subfolders.

Sure, I can replace it with a more generic argument to copy files/directories into src/main/res.

Fak3 · 2020-05-30T16:31:34Z

I believe this is more generic version of my pr #1922. Maybe this one is better, as it is more flexible. But please note that I had to add more Gradle build flags for this to work. (See my original pr)

pavelsof · 2020-06-02T10:04:15Z

@AndreMiras, I agree, it would be better if the option name makes it clear that it can be used to insert arbitrary XML in the <application> element. Should I change it?

@Fak3, thank you for jumping in! Indeed, just as you did, I also had to add com.android.support:support-v4:26.1.0 as a dependency in Gradle; but I used the android.gradle_dependencies option in buildozer.spec. Also, I did not have to enable multidex.

AndreMiras · 2020-06-02T11:45:48Z

Thanks guys for the discussion!
@pavelsof if #1922 would work for you use case and @Fak3 is willing to resume his work on it then we could go for it instead.
If we were to integrate yours, then yes I would say let's make the parameters a bit more generic and add unit tests.
Otherwise if we really need both then we would go for both.

pavelsof · 2020-06-02T14:52:19Z

@AndreMiras, yes, #1922 works for me. It would be slightly easier to use as well, because a Kivy developer would only need the paths XML, but not the <provider> boilerplate.

RobertFlatt · 2020-11-27T20:34:10Z

This would be great if this was signed off and 'dozer supported the args, I just did it by hand and inserted :

    <provider
        android:name="android.support.v4.content.FileProvider"
        android:authorities="{{ args.package }}.fileprovider"
        android:grantUriPermissions="true"
        android:exported="false">
        <meta-data
            android:name="android.support.FILE_PROVIDER_PATHS"
            android:resource="@xml/provider_paths" />
    </provider>

Also I used
android.gradle_dependencies = "com.android.support:support-core-utils:27.0.0"

I tested build and execution on api 27, 29, and 30 all good

Arbitrary html would be a good thing in general.
And this case androidx support will require a change the android:name field value

RobertFlatt · 2020-11-28T01:05:12Z

FYI, the steps to move from the depreciated packages to androidx #2020 (comment)

pavelsof · 2021-01-23T21:06:51Z

Ping! This is a polite reminder/request to please merge this PR. I have been using my python-for-android and Buildozer forks for a pet Kivy app, and there have not been problems for what is now almost a year. Content providers constitute an important thing in Android and Kivy should be able to work with them.

Fak3 · 2021-01-24T12:11:42Z

Ping! This is a polite reminder/request to please merge this PR.

I believe we have to fix #2385 first, it would not work without it

pavelsof · 2021-01-24T15:18:01Z

It works (at least for me) with the older, probably deprecated by now, android.support.v4.content way. But I agree, AndroidX would be much better.

What can we do to prod the core maintainers to say what is wrong with either PR? 😕

RobertFlatt · 2021-01-24T20:25:51Z

What can we do to prod the core maintainers to say what is wrong with either PR? 😕

I wish I knew the answer to that question 🤔

If #2385 where approved (sigh) then support here for both versions might look like this:

	{% if args.enable_androidx %}
	android:name="androidx.core.content.FileProvider"
	{% else %}
	android:name="android.support.v4.content.FileProvider"
	{% endif %}

RobertFlatt · 2021-01-24T21:16:33Z

As an enhancement I suggest a default provider_paths.xml
This would be a lot easier for the script kiddies.

For example the attached provide_paths.xml that provides all the default directories in both local storage directories.
So a custom provider_paths.xml would only be required if the user makes a custom directory, this is easy to explain.
provider_paths.txt (renamed from .xml to .txt to keep Github happy).

File belongs in pythonforandroid/bootstraps/sdl2/build/src/main/res/xml which must be created.
I have not checked if an explict copy is required in the build.

darpan5552 · 2021-03-11T16:36:45Z

Instead of Fileprovider there can be other conditions also where we need to add extra entries to Manifest. Furthermore there is no guarantee that in future there will not be more such important requirements.

Why not keep everything thing as xml file as the boilerplate code added to manifest also follows xml syntax.

Adding two parameters --extend-manifest <something.xml> and --add-xml-resource <something 2.xml> should do the thing.

RobertFlatt · 2021-03-11T16:51:43Z

Is this what you want?
https://github.com/kivy/python-for-android/blob/develop/pythonforandroid/bootstraps/sdl2/build/templates/AndroidManifest.tmpl.xml#L45

Also there is at least one xml related PR #2330 that sits and rots :(

darpan5552 · 2021-03-11T17:23:54Z

Is this what you want?
https://github.com/kivy/python-for-android/blob/develop/pythonforandroid/bootstraps/sdl2/build/templates/AndroidManifest.tmpl.xml#L45

Yes, i wanted this. It would be better if it also integrates addition of intent-filters in it. I know both are at different levels in xml tree but there are not too much use cases that in can't be handled on p4a side.

Also there is at least one xml related PR #2330 that sits and rots :(

#2330 is also a very specific case where he wants to insert intent filters manually but automating the modification of manifest file.
In contrast, i am on the side of No Automation Policy as there can be large cases for such automation. A better way could be to allow the user to write modification and we just push the modifications in its place.

Fak3 · 2021-03-11T18:02:45Z

I think the most generic thing to address all cases will be to allow p4a use custom manifest template file, via an option --manifest=/path/to/mymanifest.xml.tmpl

darpan5552 · 2021-03-11T18:22:34Z

There are some things important in default manifest file. So for using a custom manifest file, a user has to study the manifest lying under the hood. I argue that if he can go there, then what is the use of providing options, he can directly do additions right there only.

…

On Thu, 11 Mar, 2021, 11:33 pm Evstifeev Roman, ***@***.***> wrote: I think the most generic thing to address all cases will be to allow p4a use custom manifest template file, via an option --manifest=/path/to/mymanifest.xml.tmpl — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2200 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANZGQCHIUQWTAJQ5SDHC6DTTDEAVLANCNFSM4NBCEUQA> .

HeRo002 · 2022-04-07T09:45:39Z

I just asked "Has content providers been incorporated in p4a?" on https://groups.google.com/g/kivy-users/c/7VVYdkA0gjQ - and received this answer by RobertFlatt :

I think the whole content provider thing faded to irrelevance, turned out that the MediaStore can provide a uri.

I wrote this as a test case: https://github.com/Android-for-Python/Share-Send-Example

Fak3 · 2022-04-07T10:20:28Z

So how this can help with plyer camera, which requires fileprovider to work?

RobertFlatt · 2022-04-07T21:09:30Z

@Fak3 You want to save an image to shared storage on Android >= 10?
Write a temp image to local storage and then copy that to the MediaStore.

I wrote a Camera Widget that on Android can save screen shots to public storage (for photos the widget uses native image capture that handles this). https://github.com/Android-for-Python/Camera4Kivy

The save and copy code is here https://github.com/Android-for-Python/Camera4Kivy/blob/main/src/camera4kivy/preview_camerax.py#L224-L253

Fak3 · 2022-04-08T03:41:59Z

I want it to be compatible with Android 7

RobertFlatt · 2022-04-08T04:35:52Z

You don't say what "it" is, but if "it" is save a file then on Android <10 shared storage is a file system.

Fak3 · 2022-04-08T04:52:32Z

I want to capture a photo with external camera app. On Android 7 it throws an error when you just try to give an external app a filesystem path to save an image to. It only works if you properly define fileprovider in your Android manifest.

Fak3 · 2022-04-08T04:55:58Z

See kivy/plyer#549

RobertFlatt · 2022-04-08T06:27:51Z

Yep, Plyer Camera looks like it has had bit rot for several years. The design approach is obsolete.

I see that you would have that issue.

Fak3 · 2022-04-08T06:48:26Z

Working approach for Android 7 is still needed. It will take years for users to switch to Android 10

pavelsof added 3 commits May 14, 2020 22:54

Added the --content-providers option to the common build.py.

bab07b0

Added the --add-resource option to the common build.py.

ba045b6

Replaced --add-resource with --add-xml-resource in the common build.py.

bae2f5b

pavelsof mentioned this pull request May 21, 2020

Content providers kivy/buildozer#1119

Open

AndreMiras requested a review from inclement May 21, 2020 15:30

inclement reviewed May 30, 2020

View reviewed changes

AndreMiras mentioned this pull request Jun 2, 2020

Add optional android fileprovider. #1922

Open

ThomasCWright mentioned this pull request Dec 7, 2020

Implement FIleProvider in hard coded template ThomasCWright/Sudoku#13

Closed

This was referenced Dec 19, 2020

Enable androidx #2374

Closed

app crashes when using camera kivy/plyer#549

Open

Fak3 mentioned this pull request Apr 10, 2021

allow dumping and loading the manifest file #1439

Open

DexerBR mentioned this pull request Apr 18, 2022

Adds an option to allow add resources to Android res/ directory #2580

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Content providers #2200

Content providers #2200

pavelsof commented May 14, 2020

pavelsof commented May 21, 2020

AndreMiras commented May 29, 2020

inclement May 30, 2020

pavelsof Jun 2, 2020

inclement May 30, 2020

pavelsof Jun 2, 2020

Fak3 commented May 30, 2020

pavelsof commented Jun 2, 2020

AndreMiras commented Jun 2, 2020

pavelsof commented Jun 2, 2020

RobertFlatt commented Nov 27, 2020

RobertFlatt commented Nov 28, 2020

pavelsof commented Jan 23, 2021

Fak3 commented Jan 24, 2021

pavelsof commented Jan 24, 2021

RobertFlatt commented Jan 24, 2021

RobertFlatt commented Jan 24, 2021

darpan5552 commented Mar 11, 2021

RobertFlatt commented Mar 11, 2021

darpan5552 commented Mar 11, 2021 •

edited

Loading

Fak3 commented Mar 11, 2021

darpan5552 commented Mar 11, 2021 via email

HeRo002 commented Apr 7, 2022

Fak3 commented Apr 7, 2022

RobertFlatt commented Apr 7, 2022

Fak3 commented Apr 8, 2022

RobertFlatt commented Apr 8, 2022

Fak3 commented Apr 8, 2022

Fak3 commented Apr 8, 2022

RobertFlatt commented Apr 8, 2022

Fak3 commented Apr 8, 2022

Content providers #2200

Are you sure you want to change the base?

Content providers #2200

Conversation

pavelsof commented May 14, 2020

pavelsof commented May 21, 2020

AndreMiras commented May 29, 2020

inclement May 30, 2020

Choose a reason for hiding this comment

pavelsof Jun 2, 2020

Choose a reason for hiding this comment

inclement May 30, 2020

Choose a reason for hiding this comment

pavelsof Jun 2, 2020

Choose a reason for hiding this comment

Fak3 commented May 30, 2020

pavelsof commented Jun 2, 2020

AndreMiras commented Jun 2, 2020

pavelsof commented Jun 2, 2020

RobertFlatt commented Nov 27, 2020

RobertFlatt commented Nov 28, 2020

pavelsof commented Jan 23, 2021

Fak3 commented Jan 24, 2021

pavelsof commented Jan 24, 2021

RobertFlatt commented Jan 24, 2021

RobertFlatt commented Jan 24, 2021

darpan5552 commented Mar 11, 2021

RobertFlatt commented Mar 11, 2021

darpan5552 commented Mar 11, 2021 • edited Loading

Fak3 commented Mar 11, 2021

darpan5552 commented Mar 11, 2021 via email

HeRo002 commented Apr 7, 2022

Fak3 commented Apr 7, 2022

RobertFlatt commented Apr 7, 2022

Fak3 commented Apr 8, 2022

RobertFlatt commented Apr 8, 2022

Fak3 commented Apr 8, 2022

Fak3 commented Apr 8, 2022

RobertFlatt commented Apr 8, 2022

Fak3 commented Apr 8, 2022

darpan5552 commented Mar 11, 2021 •

edited

Loading