Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for python 3.12 #678

Merged
merged 1 commit into from
Oct 4, 2023
Merged

test for python 3.12 #678

merged 1 commit into from
Oct 4, 2023

Conversation

cmacdonald
Copy link
Contributor

No description provided.

@cmacdonald cmacdonald marked this pull request as draft October 3, 2023 09:54
@cmacdonald
Copy link
Contributor Author

python 3.12 not available yet under actions/setup-python. this can wait for later.

@misl6 misl6 marked this pull request as ready for review October 4, 2023 16:42
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.12 is now available on Github Actions, and the CI is ✅.

I guess we should add 3.12 support on the upcoming release.

LGTM. Thank you!

@misl6 misl6 merged commit 5a69e60 into kivy:master Oct 4, 2023
196 checks passed
@cmacdonald cmacdonald deleted the patch-2 branch October 4, 2023 16:47
@cmacdonald
Copy link
Contributor Author

should we reduce testing of interim versions of Python - e.g. just oldest and newest?

@misl6
Copy link
Member

misl6 commented Oct 4, 2023

should we reduce testing of interim versions of Python - e.g. just oldest and newest?

Mmm, that could reduce the CI running time, but do we really want to take this risk?

What we certainly do, is remove tests for python: 3.7 since reached EOL on June 2023.

@cmacdonald
Copy link
Contributor Author

cmacdonald commented Oct 4, 2023

I would keep Python 3.7 builds for longer... And if you are building, you should test, right?

One possible way to look at it - do we expect interactions between OS and python version. Or could we test most python versions on Linux, and have a more focussed CI strategy for other platforms?

@cmacdonald
Copy link
Contributor Author

PS: should setup.py specify the minimum python version:
https://stackoverflow.com/a/45362425

@cmacdonald
Copy link
Contributor Author

Should the build wheels also include Python 3.12?

@misl6
Copy link
Member

misl6 commented Oct 4, 2023

I would keep Python 3.7 builds for longer... And if you are building, you should test, right?

One possible way to look at it - do we expect interactions between OS and python version. Or could we test most python versions on Linux, and have a more focussed CI strategy for other platforms?

We can try, but I do not feel it's something super-great. IIRC, on pypy-x we had a specific pypy version that was failing for apparently no reason on macOS, and that version was neither the oldest or the newest one.

... Then the issue has been fixed "automagically", so I can't really tell you why, but I feel more comfortable to test along all the versions.

But, I'm open for a discussion (on a separate thread)

Edit: https://github.com/kivy/pyjnius/actions/runs/6409063191/job/17399475973?pr=677 (it just happens less frequently)

@misl6
Copy link
Member

misl6 commented Oct 4, 2023

Should the build wheels also include Python 3.12?

Absolutely. We need to update cibuildwheels for that.

@misl6
Copy link
Member

misl6 commented Oct 4, 2023

PS: should setup.py specify the minimum python version: https://stackoverflow.com/a/45362425

That's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants