-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for python 3.12 #678
test for python 3.12 #678
Conversation
python 3.12 not available yet under actions/setup-python. this can wait for later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.12
is now available on Github Actions, and the CI is ✅.
I guess we should add 3.12
support on the upcoming release.
LGTM. Thank you!
should we reduce testing of interim versions of Python - e.g. just oldest and newest? |
Mmm, that could reduce the CI running time, but do we really want to take this risk? What we certainly do, is remove tests for |
I would keep Python 3.7 builds for longer... And if you are building, you should test, right? One possible way to look at it - do we expect interactions between OS and python version. Or could we test most python versions on Linux, and have a more focussed CI strategy for other platforms? |
PS: should setup.py specify the minimum python version: |
Should the build wheels also include Python 3.12? |
We can try, but I do not feel it's something super-great. IIRC, on ... Then the issue has been fixed "automagically", so I can't really tell you why, but I feel more comfortable to test along all the versions. But, I'm open for a discussion (on a separate thread) Edit: https://github.com/kivy/pyjnius/actions/runs/6409063191/job/17399475973?pr=677 (it just happens less frequently) |
Absolutely. We need to update |
That's a good idea. |
No description provided.