-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Basic housekeeping #5
base: development
Are you sure you want to change the base?
Conversation
Just curious if we do need the licence in all files or in the repo root is enough? |
Its fine to remove the deprecated folder. It was just a list of old examples that were developed but I replaced them in the examples folder. Some of them don't work. I was just keeping them for reference. Everything outside the deprecated folder should be up to date. |
…to kivy3.shaders.__init__. Cleanup stl and urdl loader examples. Remove examples/_depreciated folder. Remove all __init__.py files from examples folders. Remove license headers from source files. adopt LICENSE text.
@AndreMiras you're right. I removed the license text from py source files. |
@JohnSumskas I removed the _depreciated folder from examples, fixes urdf loader example and simplifies and cleaned up urdf and stl loader examples. |
More Housekeeping
Nice that you're giving it some love, it looks promising ❤️
It's only a suggestion and I'm not maintaining this project. It feels overkill and extra work, but actually it's a strategy to get things done. For instance even though my knowledge on this project is very limited, it's still likely that I try to understand and approve/merge something as trivial as deleting a folder called |
@JohnSumskas With this PR I do basic housekeeping and try to get an overview of all your enhancements. Some examples seem to be almost duplicates of others, or behave identical. Can you tell me what the depreciated folder is good for and which examples are up to date please?