Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes xcassets #951

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Novfensec
Copy link

Introduction

This pull-request is related to the below bug;

Changes

  • Reworked the _buildimage function in kivy_ios.tools.external.xcassets to build correct image sizes.
  • Made an adjustment to stop kivy-ios from overriding user defined assets like Images.xcassets.AppIcon.appiconset and Images.xcassets.LaunchImage.launchimage if they are already present.
  • Test workflow run at https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12210952062
  • Hopefully passing all steps nicely.

With kivy_ios merging the below pull-requests along with this makes it usable along with buildozer:

Testing

@Novfensec
Copy link
Author

Hey @AndreMiras , I fixed the icon generation issues within the icon and _generate function. You can test build using branch patch-2 of https://github.com/Novfensec/kivy-ios/tree/patch-2 .

buildozer -v ios debug

@AndreMiras
Copy link
Member

AndreMiras commented Dec 10, 2024

Thank you for spending time on that one 🙏
Would you mind editing the PR to not touch the formatting and address only the bug you mentioned in _buildimage()
Honestly I wish we had a formatter in the CI so it didn't have to be a recurring topic

@Novfensec
Copy link
Author

Thank you for spending time on that one 🙏
Would you mind editing the PR to not touch the formatting and address only the bug you mentioned in _buildimage()
Honestly I wish we had a formatter in the CI so it didn't have to be a recurring topic

I used black for formatting. So, I'll just realign the list back to their original style. Please wait!!

@Novfensec
Copy link
Author

@AndreMiras Reverted Dict formatting to original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants