Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow properties to be set #232

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Do not allow properties to be set #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions main/kernel/Configuration.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,22 +184,19 @@ class Property : public ConfigurationEntry {
Property(ConfigurationSection* parent, const String& name, const T& defaultValue = T(), const bool secret = false)
: name(name)
, secret(secret)
, value(defaultValue)
, defaultValue(defaultValue) {
parent->add(*this);
}

void set(const T& value) {
this->value = value;
configured = true;
}

const T& get() const {
return configured ? value : defaultValue;
}

void load(const JsonObject& json) override {
if (json[name].is<JsonVariant>()) {
set(json[name].as<T>());
value = json[name].as<T>();
configured = true;
} else {
reset();
}
Expand Down Expand Up @@ -241,10 +238,6 @@ class ArrayProperty : public ConfigurationEntry {
parent->add(*this);
}

void set(const std::list<T>& entries) {
this->entries = entries;
}

const std::list<T>& get() const {
return entries;
}
Expand Down
Loading