Merge pull request #232 from kivancsikert/config/read-only

Do not allow properties to be set
kivancsikert · Oct 23, 2024 · 0c5b0c8 · 0c5b0c8
2 parents f02654f + edfe28c
commit 0c5b0c8
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/main/kernel/Configuration.hpp b/main/kernel/Configuration.hpp
@@ -184,22 +184,19 @@ class Property : public ConfigurationEntry {
     Property(ConfigurationSection* parent, const String& name, const T& defaultValue = T(), const bool secret = false)
         : name(name)
         , secret(secret)
+        , value(defaultValue)
         , defaultValue(defaultValue) {
         parent->add(*this);
     }
 
-    void set(const T& value) {
-        this->value = value;
-        configured = true;
-    }
-
     const T& get() const {
         return configured ? value : defaultValue;
     }
 
     void load(const JsonObject& json) override {
         if (json[name].is<JsonVariant>()) {
-            set(json[name].as<T>());
+            value = json[name].as<T>();
+            configured = true;
         } else {
             reset();
         }
@@ -241,10 +238,6 @@ class ArrayProperty : public ConfigurationEntry {
         parent->add(*this);
     }
 
-    void set(const std::list<T>& entries) {
-        this->entries = entries;
-    }
-
     const std::list<T>& get() const {
         return entries;
     }