-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queryStatisticsCollectionForQuantity #83
Conversation
540463b
to
be7612a
Compare
Expo preview is ready for review. There should soon be a new native build available here |
I think this looks good! 👍 An update to make the example run in XCode 15 (I haven't done it myself yet) would be nice as well, but it would fit better in a PR of its own. Two things before we merge this PR:
|
@davidyang Hope I didn't put you off. To clarify - I'd be happy to merge this if the linting goes through :) Let me know if you need any support. |
Hi Robert - definitely not, just busy with other stuff, hope to get back to
this shortly! Thanks for the follow-up, appreciate it!
…On Wed, Nov 15, 2023 at 6:44 PM Robert Herber ***@***.***> wrote:
@davidyang <https://github.com/davidyang> Hope I didn't put you off. To
be clear I'd be happy to merge this if the linting goes through :)
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACNRMP6NRNK377DOXBFBLYEVHVVAVCNFSM6AAAAAA6YJO4GSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGQ3TGNZVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
+1 |
was able to integrate this PR into my project, but I couldnt get code hints. In addition, there seems to be an issue, as the
Today is Feb 8, but I get some values that seem to be reported on Feb 9 and 10? I will be happy to test again if needed. Here is some sample data:
|
@robertherber (CC: @davidyang ) Resolved lint errors, added an entry in the example app and did some refactors. Should I make a separate PR? |
Yeah, I guess it's easier as a separate PR 👍 Thanks both of you @davidyang and @taisuke-j for contributing! 🙂 |
@robertherber No problem! Here is the PR: #111 |
Closing since this was merged with #111, thanks guys! |
Hi @robertherber - tested this out and works for getting data out. Wanted to run it by you, looking more at it I'm realizing there's some type definition issues. I can iron those out if you think this is on the right path.
Also, I have XCode 15 and had to make some pretty messy changes to the examples/ almost to the point I'm not sure it's reproducible. I'll check in those changes on another branch
updated-example