Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queryStatisticsForQuantity to resolve when competition handler returns nil statistics #79

Conversation

josh-
Copy link
Contributor

@josh- josh- commented Sep 25, 2023

Attempts to resolve #78 by calling resolve with the newly-created dictionary object when stats is nil.

Moves from the existing if let to a guard let based on existing usages elsewhere (for example, here). Thus, the majority of the changes are whitespace, so would recommend viewing the diff without whitespace.

@github-actions
Copy link

Expo preview is ready for review.

There should soon be a new native build available here

With that installed just scan this QR code:
QR Preview

@robertherber robertherber merged commit bc400c2 into kingstinct:master Sep 25, 2023
2 of 3 checks passed
@ike44est
Copy link

is it possible to get this build out to npm by chance? still seeing this issue in 7.3.0, happy to help however I can!

@robertherber
Copy link
Member

@josh- @ike44est Released in 7.3.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HealthKit.queryStatisticsForQuantity()'s Promise (and other functions too) stuck in Pending
3 participants