Revert UUID changes #123
Merged
Revert UUID changes #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expo preview is ready for review. There should soon be a new native build available here With that installed just scan this QR code: |
|
@mphill I didn't have time to test it out. How critical is it? In general agree allowing specifying a non-UUID string makes sense. |
|
I would approve this to restore the previous functionality. However, it is more complicated to implement and requires more testing, such as deleting multiple nutrients with the same UUID when using that predicate appears to error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to revert this; it does not work as expected. I instead used RFC 4122 UUIDs to manage this.