Fix Infinite renders/calls for using useSubscribeToChanges

[Nirzhuk]

If we use the same example from the documentation we will have an permanent re-rendering per tick which causes a huge memory leak which with 2 of the same, will crash any app.

Why is this caused?

update function is revalue it due useSubscribeToChanges because update have an setResult so the useEffect for the update will trigger infinite without even subscribing.

Solution:
Removing update from the dependencies from useEffect will only trigger 1 time so we can have initial values, then we depends totally from useSubscribeToChanges to trigger update which is the porpuse of the subscribing hook.

[robertherber]

@Nirzhuk I realized this should be reverted since it breaks the rules of hooks (the linting workflow had fallen out of grace for some reason).

The way to do this is ensuring that you don't send in new parameters on every render (i.e. make sure the dates you're sending in are stable and not changing all the time).

[Nirzhuk]

@Nirzhuk I realized this should be reverted since it breaks the rules of hooks (the linting workflow had fallen out of grace for some reason).

The way to do this is ensuring that you don't send in new parameters on every render (i.e. make sure the dates you're sending in are stable and not changing all the time).

I feel the rules of hooks are not specify the way you can control your hooks, useEffect(call,[]) only needs to triggers on render, which initialize our data after that useSubscribeToChanges gets all the responsability to get the info.
And rules of hooks specify you can use them to trigger in the point you need of the life of the component (which in this case is the creation).

I tried to use your example code but simplied (without the map) and got the same result. I understand your point tho. Thanks for writing a comment about it.