Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action workflows #7

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Add GitHub Action workflows #7

merged 12 commits into from
Aug 15, 2023

Conversation

kingdonb
Copy link
Owner

Superseding #5 (this PR includes it)

Fixes:

Also fixes:

  • Needs formal testing #6
  • We can't incorporate this upstream before it's release-quality, so test this once it is merged. We have to merge it to find out if it works, since actions are only defined in the default/main branch. This PR includes a workflow_dispatch trigger that we can run locally to see how it works in-situ, before we attempt to tag any release.

Kingdon Barrett added 12 commits August 14, 2023 18:21
add some specificity, refining
5c99be9 
ChatGPT has identified download_and_analyze_links as a likely culprit
We'll now delve into the files that make it up and see what we can fix

Signed-off-by: Kingdon Barrett <[email protected]>
make use of helpers
b5c42ab 
Signed-off-by: Kingdon Barrett <[email protected]>
try to implement chatgpt's refinements
94ec629 
Signed-off-by: Kingdon Barrett <[email protected]>
fix some bugs according to gpt
b3aec77 
Signed-off-by: Kingdon Barrett <[email protected]>
fix encoding issues to parse all the links
0718c52 
This change resolves all outstanding crashes and reduces the final
output to something less than we were emitting before. (Did the links
that dropped out of the report incorrectly represent an error?)

Signed-off-by: Kingdon Barrett <[email protected]>
use link_text setter
3fe4b47 
Signed-off-by: Kingdon Barrett <[email protected]>
add a normalize target in the makefile
3205ff9 
Signed-off-by: Kingdon Barrett <[email protected]>
introducing summary.rb
5fb238b 
Signed-off-by: Kingdon Barrett <[email protected]>
summary reporting for CI
c108da7 
Signed-off-by: Kingdon Barrett <[email protected]>
Emit summary reports when summary.rb is called
1d264ea 
The interesting report is pr-summary.csv because it ostensibly tells
what wrong things were caused by this PR, such that we cannot merge it
without fixing them.

May also be interested in baseline-unresolved.csv so we can start to
tackle some of the issues that are in the deployed website.

Signed-off-by: Kingdon Barrett <[email protected]>
the action according to gpt
4bfa1c8 
Signed-off-by: Kingdon Barrett <[email protected]>
github scripts and test workflow
469b770 
Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb merged commit e45e3ea into main Aug 15, 2023
@kingdonb kingdonb deleted the action branch August 15, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kingdonb