-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needs formal testing #6
Comments
It is definitely testable in-place. I have tested it and found: which should be resolved before we try deploying it to fluxcd/website. (It should also be tagged, and I'd suggest creating some additional tests created for the ruby files.) Anyway, we can see from the test output here: It runs, fails with exit code 2 (it's buried a little bit, but if you dig through the output for 'exit code 2' you find it):
Then it attaches the summary PR csv (this explains what did this PR do to trigger the failing check!) If the test passes, we move onto the baseline report which is also interesting, but shouldn't fail the check. That one gets uploaded, only if it contains any useful records. Finally, we should be able to see that when no more issues are triggered in either report, the CSV uploads will stop. One should only need these CSVs when there are really a lot of errors (like right now.) |
The testing has been rigorous but informal. Round two now |
No way we can close #3 without adding some formal tests.
The text was updated successfully, but these errors were encountered: