Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jep/stpa with fta #21

Merged
merged 33 commits into from
Dec 22, 2023
Merged

Jep/stpa with fta #21

merged 33 commits into from
Dec 22, 2023

Conversation

Drakae
Copy link
Contributor

@Drakae Drakae commented Dec 21, 2023

Enhanced FTA support and added an option to automatically generate a Fault Tree from an STPA file.

Drakae added 30 commits October 24, 2023 10:25
@Drakae
causal factors for scenarios can be stated
df7aa3f
@Drakae
added process for creating fault trees from stpa
b5f8757
@Drakae
invisible node for gates with description (WIP)
ea55d3f
@Drakae
invisible node for gates with description
17cc263
@Drakae
adjust cut set highlighting for gates with description
f587aba
@Drakae
stpa to fta
0b308c1
@Drakae
resetting cut set option for new model
47daec8
@Drakae
adjusted styling of description node (WIP)
daabd9e
@Drakae
adjusted layout
1accdaa
@Drakae
merge outgoing edges
181cb46
@Drakae
junction points are drawn
cfc9b54
@Drakae
label management for fta
21da3ff
@Drakae
fixed node size for long labels
9c50ec3
@Drakae
adjusted fta visualization
641eff6
@Drakae
model order for fta
185c64a
@Drakae
context menu in webview
0f605de
@Drakae
context menu: refactoring
e3633ef
@Drakae
context-menu: refactoring
465d261
@Drakae
adjjusted layout config
3e602a3
@Drakae
context menu: adjusted colors
3082bb9
@Drakae
adjusted cursor visualization
e8190e5
@Drakae
adjusted stpa label id
bd4abe8
@Drakae
action in context menu works
17da973
@Drakae
fixed clicking on label
f4b4ac6
@Drakae
context menu works also for gates with descriptions
bd53aa9
@Drakae
context menu: added minimal cut set action
b5e4c5d
@Drakae
highlighting for top of analysis is not the root (WIP)
df5b22c
@Drakae
fixed spofs
250d166
@Drakae
fixed highlighting for gate with desc as top of analysis
a8b5cbb
@Drakae
translation of scenarios for UCAs to fta
944bc4c
@Drakae Drakae requested a review from Eddykasp December 21, 2023 14:56
Eddykasp
Eddykasp approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues and some improvement suggestions but other than lgtm 👍

extension/src-language-server/fta/diagram/fta-diagram-generator.ts Outdated Show resolved Hide resolved
extension/src-language-server/fta/diagram/fta-diagram-generator.ts Outdated Show resolved Hide resolved
extension/src-language-server/fta/diagram/fta-layout-config.ts Outdated Show resolved Hide resolved
extension/src-language-server/fta/diagram/fta-layout-config.ts Outdated Show resolved Hide resolved
extension/src-language-server/fta/diagram/fta-model.ts Outdated Show resolved Hide resolved
extension/src-webview/css/fta-diagram.css Outdated Show resolved Hide resolved
extension/src-webview/fta/fta-model.ts Show resolved Hide resolved
extension/src-webview/fta/fta-views.tsx Show resolved Hide resolved
extension/src/actions.ts Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@Drakae Drakae merged commit 400c228 into master Dec 22, 2023
1 check passed
@Drakae Drakae deleted the jep/stpaWithFta branch December 22, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drakae @Eddykasp