Skip to content

Commit

Permalink
mka feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Drakae committed Dec 19, 2024
1 parent 777827f commit 3648058
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion extension/src-context-table/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
"jsx": "react",
"jsxFactory": "jsx"
}
}
}
2 changes: 1 addition & 1 deletion extension/src-diagram-snippets/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"module": "commonjs",
"moduleResolution": "node",
"jsx": "react",
}
}
}
2 changes: 1 addition & 1 deletion extension/src-language-server/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ addDiagramHandler(connection, shared);

addSTPANotificationHandler(connection, stpa, shared);
addFTANotificationHandler(connection, fta, shared);
addNotificationHandler(connection, shared, stpa, fta);
addNotificationHandler(connection, shared, stpa, fta);
2 changes: 1 addition & 1 deletion extension/src-language-server/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
"moduleResolution": "Node16",
},
"exclude": ["../src-context-table"]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { FTANode, FTA_GRAPH_TYPE, FTA_NODE_TYPE } from "../fta/fta-model";

@injectable()
export class ContextMenuProvider implements IContextMenuItemProvider {
getItems(root: Readonly<SModelRootImpl>, lastMousePosition?: Point): Promise<LabeledAction[]> {
getItems(root: Readonly<SModelRootImpl>, _lastMousePosition?: Point): Promise<LabeledAction[]> {
if (root.type === FTA_GRAPH_TYPE) {
// find node that was clicked on
let clickedNode: FTANode | undefined;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ export function FeatherIcon(props: { iconId: string }): VNode {
class={classes}
props={{innerHTML: icons[props.iconId].toString()}}
/>;
}
}
2 changes: 1 addition & 1 deletion extension/src-webview/options/options-panel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ export class OptionsPanel extends SidebarPanel {
get icon(): VNode {
return <FeatherIcon iconId={"sliders"}/>;
}
}
}
2 changes: 1 addition & 1 deletion extension/src-webview/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
"module": "commonjs",
"moduleResolution": "node",
"jsx": "react",
}
}
}
2 changes: 1 addition & 1 deletion extension/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -542,4 +542,4 @@ function registerDiagramSnippetWebview(manager: StpaLspVscodeExtension, context:
manager.addSnippet(uri);
})
);
}
}
2 changes: 1 addition & 1 deletion extension/src/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
"moduleResolution": "node",
"allowSyntheticDefaultImports": true
}
}
}
2 changes: 2 additions & 0 deletions extension/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import { LanguageClient } from "vscode-languageclient/node";
import { StpaLspVscodeExtension } from "./language-extension";
import { StorageService } from "./storage-service";

// TODO: rename utils files to be more descriptive

/**
* Creates a quickpick containing the values "true" and "false". The selected value is set for the
* configuration option determined by {@code id}.
Expand Down

0 comments on commit 3648058

Please sign in to comment.