154 compute vehicle data all at once #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…your garbage collector, thanks)
NicoBiernat
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Your refactor of the vehicle service and track service looks good. I suggest that we merge it to development and then pull it into #163 to complete the error handling. Then we proceed with profiling and optimizing.
One thing that we might have to think about is whether some failed calculation in e.g. getVehicleData should let the whole request fail or if we might send partial responses with just the failed computed field missing.
Since you changed something in the routes, we will probably have some merge conflicts, but we'll handle them in #163.
Please use a linter to find unused imports and other easy to fix issues in the future.
JulianGrabitzky
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperated logic and database queries in vehicle service (see #154). Sadly this did not produce the desired result as it decreased the route
PUT /api/vehicles/apponly a little bit. More profiling on this needs to be done.One more note on these weird looking TODOs above every null check: This will be removed in near future (probably another PR) after #163 gets merged.