Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy properties to the SModel already during initial SModel generation #203

Merged
merged 4 commits into from
Nov 8, 2024
Merged

copy properties to the SModel already during initial SModel generation #203

merged 4 commits into from
Nov 8, 2024

Conversation

NiklasRentzCAU
Copy link
Member

for client-only layout.

@NiklasRentzCAU NiklasRentzCAU added enhancement New feature or request LSP Affect the klighd language server. labels Sep 28, 2024
Eddykasp
Eddykasp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NiklasRentzCAU NiklasRentzCAU marked this pull request as ready for review November 8, 2024 14:58
@NiklasRentzCAU NiklasRentzCAU merged commit 9dd279c into master Nov 8, 2024
3 checks passed
@NiklasRentzCAU NiklasRentzCAU deleted the nre/client-only-layout branch November 8, 2024 15:02
NiklasRentzCAU added a commit that referenced this pull request Nov 21, 2024
@NiklasRentzCAU
fixed NPE in refresh diagram aciton missed in #203
a80788c
NiklasRentzCAU added a commit that referenced this pull request Nov 21, 2024
@NiklasRentzCAU
fixed NPE in refresh diagram aciton missed in #203
bf5fa11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request LSP Affect the klighd language server.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasRentzCAU @Eddykasp