Interactive mr tree

[soerendomroes]

No description provided.

[soerendomroes]

@NiklasRentzCAU do you know the error message?

[soerendomroes]

Somehow, moving the constraint serializer resulted in no constraints being serialized since the LSP client does not seem to be the correct one.

[NiklasRentzCAU]

@NiklasRentzCAU do you know the error message?

Yes - publishing to Maven Central required us to also check in valid JavaDoc. The check now also goes through the Javadoc, and alongside quite a few warnings for missing JavaDoc there are four errors in your new JavaDoc, see the non-capitalized "error: ..." markings in the actions message: InteractiveUtil has a @returns tag (should be @return), MrTreeInteractiveLanguageServerExtension, PositionConstraintReevaluation, and RectpackingInteractiveLanguageServerExtension refer to variables with @param that do not exist, probably because they have been renamed.

[soerendomroes]

Yes - publishing to Maven Central required us to also check in valid JavaDoc. The check now also goes through the Javadoc, and alongside quite a few warnings for missing JavaDoc there are four errors in your new JavaDoc, see the non-capitalized "error: ..." markings in the actions message: InteractiveUtil has a @returns tag (should be @return), MrTreeInteractiveLanguageServerExtension, PositionConstraintReevaluation, and RectpackingInteractiveLanguageServerExtension refer to variables with @param that do not exist, probably because they have been renamed.

There are a lot of error messages to begin with on the master. Did we just not fix all the issues on main before activating this? @NiklasRentzCAU

[soerendomroes]

If we enforce this, do we have a checkstyle configuration for this?

[soerendomroes]

This enforces comments for Data classes such as CheckedImagesAction and ConstraintProperty. How do I even add a comment for a data class constructor? I do not think that the current configuration is reasonable.

[soerendomroes]

My bad, the rest are Errors and warnings.

[soerendomroes]

@NiklasRentzCAU the last commit creates and uses the IActionHandler service interface properly for the interactive layout handlers. I plan to use this infrastructure for the structure-based-editing handler too. Please have a look at this and ask questions or give feedback.

[NiklasRentzCAU]

Looks good! I left a few minor comments in the code.

[NiklasRentzCAU]

For clarification of this PR: This is not only the mrtree interactive, but also a cleanup and restructuring of the existing interactive code.
Do you think we should spuash these changes when merging or are the changes in the commits of this PR clean enough?