Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.99.x-prod][SRVLOGIC-245] - Add missing labels for internal OSL bundle validation #25

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

ricardozanini
Copy link
Member

Description of the change:
Added the required labels for internal OSL Bundle validation.
There are also a few changes in the go.sum giving that I've regen the manifests. @rgdoliveira please take a look to see if any changes might impact the build.

Another thing to note is the inclusion of the new CRD in the manifests, given that we introduced it upstream. Weirdly I didn't see any test errors since this is a must manifest for the operator to run cc @domhanak

Motivation for the change:
See https://issues.redhat.com/browse/SRVLOGIC-245

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Makefile.osl Outdated Show resolved Hide resolved
@rgdoliveira
Copy link
Member

Even with this PR the CVP is still failing with the same error:

A list of required infrastructure-related annotations:
 * features.operators.openshift.io/disconnected
 * features.operators.openshift.io/fips-compliant
 * features.operators.openshift.io/proxy-aware
 * features.operators.openshift.io/tls-profiles
 * features.operators.openshift.io/token-auth-aws
 * features.operators.openshift.io/token-auth-azure
 * features.operators.openshift.io/token-auth-gcp
 
The test will pass with SUCCESS if:
 * all the required infrastructure feature annotations are present in the operator CSV file
 AND
 * all the required infrastructure feature annotations are set to string "true" or "false"

so IIUC, the changes did on this PR are not actually adding those annotations to the CSV file but just to the dockerfile?

Signed-off-by: Ricardo Zanini <[email protected]>
@rgdoliveira rgdoliveira merged commit 54beb6c into kiegroup:9.99.x-prod Mar 5, 2024
1 of 4 checks passed
@ricardozanini ricardozanini deleted the srvlogic-245 branch March 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants