[9.99.x-prod] SRVLOGIC-219: Update Operator's manifests to reflect devmode and builder images #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der images Fix to remove latest tag and use tag form code-freeze cut-off date
Co-authored-by: Jakub Schwan <[email protected]>
rgdoliveira
approved these changes
Feb 29, 2024
jakubschwan
approved these changes
Feb 29, 2024
ricardozanini
approved these changes
Feb 29, 2024
| @@ -15,7 +15,7 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
|
|
|||
| FROM registry.redhat.io/openshift-serverless-1-tech-preview/logic-rhel8-operator:1.32.0 AS builder | |||
| FROM registry.redhat.io/openshift-serverless-1-tech-preview/logic-swf-builder-rhel8:1.32.0 AS builder | |||
There was a problem hiding this comment.
This doesn't matter at all since it's not used, but to test and readme.
|
Can you please fix the CI? |
|
CI is failing because we removed the go.work files on 9.99.x-prod branch to be able to build on OSBS with cachito. Can't we just ignore the CI failures as we have been doing so far? |
|
+1 we discussed this during #22 I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes use of latest and incorrect image in example dockerfile use.
Superseeds #23 as one commit was not pulled into it from fork for some reason