Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x] [JBPM-10242] Allow the possibility of disabling linear search for removeJob and getTimerByName operations #2444

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 2, 2024

Backport: #2441

Note: CI is not automatically triggered on backported PRs, please comment 'ok to test' to launch Jenkins jobs

Fix https://issues.redhat.com/browse/JBPM-10242

…oveJob and getTimerByName operations (#2441)

* Try to cancel timer always, and only search if timer cancellation fails

* Skipping list search completely if !searchIfFailed

* [JBPM-10242] Always skipping linear search

Unless explicilty stated with property org.jbpm.ejb.timer.linear.search

* [JBPM-10242] Disable linear search on condition

Setting org.jbpm.ejb.timer.disable.linear.search and
org.jbpm.ejb.timer.disable.linear.remove to true

* [JBPM-10242] Fixing integration tests

---------

Co-authored-by: krisv <[email protected]>
@gmunozfe
Copy link
Member

gmunozfe commented Oct 3, 2024

jenkins test this

@gmunozfe
Copy link
Member

gmunozfe commented Oct 3, 2024

jenkins do fdb

@mareknovotny
Copy link
Member

There are compiler errors, are we missing some other commits here?

[2024-10-03T06:46:29.522Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project drools-core: Compilation failure: Compilation failure: 
[2024-10-03T06:46:29.522Z] [ERROR] /home/jenkins/workspace/KIE/7.67.x/pullrequest/jbpm-7.67.x.pr/bc/kiegroup_drools/drools-core/src/main/java/org/drools/core/event/ProcessEventSupport.java:[33,33] cannot find symbol
[2024-10-03T06:46:29.522Z] [ERROR]   symbol:   class ProcessDataChangedEvent
[2024-10-03T06:46:29.522Z] [ERROR]   location: package org.kie.api.event.process
[2024-10-03T06:46:29.522Z] [ERROR] /home/jenkins/workspace/KIE/7.67.x/pullrequest/jbpm-7.67.x.pr/bc/kiegroup_drools/drools-core/src/main/java/org/drools/core/event/rule/impl/ProcessDataChangedEventImpl.java:[20,33] cannot find symbol
[2024-10-03T06:46:29.522Z] [ERROR]   symbol:   class ProcessDataChangedEvent
[2024-10-03T06:46:29.522Z] [ERROR]   location: package org.kie.api.event.process
[2024-10-03T06:46:29.522Z] [ERROR] /home/jenkins/workspace/KIE/7.67.x/pullrequest/jbpm-7.67.x.pr/bc/kiegroup_drools/drools-core/src/main/java/org/drools/core/event/rule/impl/ProcessDataChangedEventImpl.java:[24,74] cannot find symbol
[2024-10-03T06:46:29.522Z] [ERROR]   symbol: class ProcessDataChangedEvent
[2024-10-03T06:46:29.522Z] [ERROR] /home/jenkins/workspace/KIE/7.67.x/pullrequest/jbpm-7.67.x.pr/bc/kiegroup_drools/drools-core/src/main/java/org/drools/core/event/ProcessEventSupport.java:[186,19] cannot find symbol
[2024-10-03T06:46:29.522Z] [ERROR]   symbol:   class ProcessDataChangedEvent
[2024-10-03T06:46:29.522Z] [ERROR]   location: class org.drools.core.event.ProcessEventSupport
[2024-10-03T06:46:29.522Z] [ERROR] -> [Help 1]
[2024-10-03T06:46:29.522Z] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project drools-core: Compilation failure
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
[2024-10-03T06:46:29.522Z]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
[2024-10-03T06:46:29.522Z]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
[2024-10-03T06:46:29.522Z]     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
[2024-10-03T06:46:29.522Z]     at java.lang.reflect.Method.invoke (Method.java:566)
[2024-10-03T06:46:29.522Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
[2024-10-03T06:46:29.522Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
[2024-10-03T06:46:29.522Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
[2024-10-03T06:46:29.522Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[2024-10-03T06:46:29.522Z] Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure
[2024-10-03T06:46:29.522Z]     at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute (AbstractCompilerMojo.java:1220)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.plugin.compiler.CompilerMojo.execute (CompilerMojo.java:187)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
[2024-10-03T06:46:29.522Z]     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
[2024-10-03T06:46:29.523Z]     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
[2024-10-03T06:46:29.523Z]     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
[2024-10-03T06:46:29.523Z]     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
[2024-10-03T06:46:29.523Z]     at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
[2024-10-03T06:46:29.523Z]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
[2024-10-03T06:46:29.523Z]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
[2024-10-03T06:46:29.523Z]     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
[2024-10-03T06:46:29.523Z]     at java.lang.reflect.Method.invoke (Method.java:566)
[2024-10-03T06:46:29.523Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
[2024-10-03T06:46:29.523Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
[2024-10-03T06:46:29.523Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
[2024-10-03T06:46:29.523Z]     at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

@gmunozfe
Copy link
Member

gmunozfe commented Oct 7, 2024

@mareknovotny yes, it's missing the backport of this
kiegroup/droolsjbpm-knowledge#646
it's done for 7.67.x-blue, but not for 7.67.x:
kiegroup/droolsjbpm-knowledge#648

@gmunozfe
Copy link
Member

gmunozfe commented Oct 7, 2024

@mareknovotny yes, it's missing the backport of this kiegroup/droolsjbpm-knowledge#646 it's done for 7.67.x-blue, but not for 7.67.x: kiegroup/droolsjbpm-knowledge#648

Added PRs for 7.67.x (I don't know why they weren't cherry-picked)
kiegroup/droolsjbpm-knowledge#650
kiegroup/droolsjbpm-integration#3067

@mareknovotny
Copy link
Member

jenkins retest this please

@gmunozfe
Copy link
Member

gmunozfe commented Oct 9, 2024

jenkins do fdb

@gmunozfe
Copy link
Member

gmunozfe commented Oct 9, 2024

@fjtirado this is ready to merge

@fjtirado fjtirado merged commit 9f8c6ae into 7.67.x Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants