Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add S3 Accounting Dashboard #1146

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

✨ Add S3 Accounting Dashboard #1146

wants to merge 1 commit into from

Conversation

XuTheBunny
Copy link
Contributor

🚧 🚧 🚧 WORKING IN PROGRESS 🚧 🚧 🚧

Screen Shot 2021-10-27 at 4 08 50 AM

Screen Shot 2021-10-27 at 4 09 02 AM

Closes #1143

@XuTheBunny XuTheBunny added the feature New functionality label Oct 27, 2021
@XuTheBunny XuTheBunny requested a review from znatty22 October 27, 2021 08:12
@XuTheBunny XuTheBunny self-assigned this Oct 27, 2021
@XuTheBunny XuTheBunny force-pushed the s3-dashboard branch 2 times, most recently from 4d466a3 to bccc758 Compare November 6, 2021 08:12
@netlify
Copy link

netlify bot commented Nov 6, 2021

βœ”οΈ Deploy Preview for kf-ui-data-tracker ready!

πŸ”¨ Explore the source changes: 4d466a3

πŸ” Inspect the deploy log: https://app.netlify.com/sites/kf-ui-data-tracker/deploys/618638ea6d416b0007273604

😎 Browse the preview: https://deploy-preview-1146--kf-ui-data-tracker.netlify.app/

@netlify
Copy link

netlify bot commented Nov 6, 2021

βœ”οΈ Deploy Preview for kf-ui-data-tracker ready!

πŸ”¨ Explore the source changes: bf282de

πŸ” Inspect the deploy log: https://app.netlify.com/sites/kf-ui-data-tracker/deploys/61f0f454d2d6840007947088

😎 Browse the preview: https://deploy-preview-1146--kf-ui-data-tracker.netlify.app/

@XuTheBunny XuTheBunny force-pushed the s3-dashboard branch 3 times, most recently from 3d449b6 to c1881da Compare November 11, 2021 15:36
@XuTheBunny XuTheBunny force-pushed the s3-dashboard branch 2 times, most recently from 556b53b to fbe57eb Compare November 12, 2021 02:16
@XuTheBunny XuTheBunny force-pushed the s3-dashboard branch 4 times, most recently from b33d006 to 1b6ff8d Compare November 13, 2021 03:06
@znatty22
Copy link
Member

@XuTheBunny Can you modify the s3 dashboard list view so that only the storage analyses for studies within the current org are listed? We probably shouldn't show a user storage analyses for a study that isn't in their current org right?

@znatty22
Copy link
Member

Can we make columns in the table sortable (for all three tabs)?

image

@znatty22
Copy link
Member

Could we also paginate each of the tables in the tab views?

Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more requests

color: '#21ba45',
},
missing: {
title: ' files in S3 with different content than expected',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: ' files in S3 with different content than expected',
title: ' files in upload manifest but missing in S3',

missing: {
title: ' files in S3 with different content than expected',
description:
'This metric is computed by counting the urls in the upload manifest(s) whose hash value is different than the hash value in the S3 inventory. These items could indicate corrupted uploads or S3 objects that have been overwritten with different content since the time of upload.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'This metric is computed by counting the urls in the upload manifest(s) whose hash value is different than the hash value in the S3 inventory. These items could indicate corrupted uploads or S3 objects that have been overwritten with different content since the time of upload.',
'This metric is computed by counting the hashes in the upload manifest(s) that were not found in the S3 inventory. These items could indicate corrupted uploads or S3 objects that have been overwritten with different content since the time of upload.',

study {
id
kfId
name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add shortName?

history.push(`/s3-accounting/${node.study.kfId}#comparison`)
}
>
<Table.Cell>{node.study.name}</Table.Cell>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Table.Cell>{node.study.name}</Table.Cell>
<Table.Cell>{node.study.shortName}</Table.Cell>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Accounting Dashboard
2 participants