-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ Add S3 Accounting Dashboard #1146
base: master
Are you sure you want to change the base?
Conversation
4d466a3
to
bccc758
Compare
βοΈ Deploy Preview for kf-ui-data-tracker ready! π¨ Explore the source changes: 4d466a3 π Inspect the deploy log: https://app.netlify.com/sites/kf-ui-data-tracker/deploys/618638ea6d416b0007273604 π Browse the preview: https://deploy-preview-1146--kf-ui-data-tracker.netlify.app/ |
βοΈ Deploy Preview for kf-ui-data-tracker ready! π¨ Explore the source changes: bf282de π Inspect the deploy log: https://app.netlify.com/sites/kf-ui-data-tracker/deploys/61f0f454d2d6840007947088 π Browse the preview: https://deploy-preview-1146--kf-ui-data-tracker.netlify.app/ |
3d449b6
to
c1881da
Compare
556b53b
to
fbe57eb
Compare
fbe57eb
to
9eca7a9
Compare
b33d006
to
1b6ff8d
Compare
@XuTheBunny Can you modify the s3 dashboard list view so that only the storage analyses for studies within the current org are listed? We probably shouldn't show a user storage analyses for a study that isn't in their current org right? |
1b6ff8d
to
8520a4d
Compare
Could we also paginate each of the tables in the tab views? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more requests
color: '#21ba45', | ||
}, | ||
missing: { | ||
title: ' files in S3 with different content than expected', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: ' files in S3 with different content than expected', | |
title: ' files in upload manifest but missing in S3', |
missing: { | ||
title: ' files in S3 with different content than expected', | ||
description: | ||
'This metric is computed by counting the urls in the upload manifest(s) whose hash value is different than the hash value in the S3 inventory. These items could indicate corrupted uploads or S3 objects that have been overwritten with different content since the time of upload.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'This metric is computed by counting the urls in the upload manifest(s) whose hash value is different than the hash value in the S3 inventory. These items could indicate corrupted uploads or S3 objects that have been overwritten with different content since the time of upload.', | |
'This metric is computed by counting the hashes in the upload manifest(s) that were not found in the S3 inventory. These items could indicate corrupted uploads or S3 objects that have been overwritten with different content since the time of upload.', |
study { | ||
id | ||
kfId | ||
name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add shortName
?
src/s3Accounting/views/ListView.js
Outdated
history.push(`/s3-accounting/${node.study.kfId}#comparison`) | ||
} | ||
> | ||
<Table.Cell>{node.study.name}</Table.Cell> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Table.Cell>{node.study.name}</Table.Cell> | |
<Table.Cell>{node.study.shortName}</Table.Cell> |
8520a4d
to
bf282de
Compare
π§ π§ π§ WORKING IN PROGRESS π§ π§ π§
Closes #1143