Merge pull request #746 from kids-first/fix-missing-values

🐛 Fix processing of missing value list

creator/data_templates/factories.py

@@ -41,7 +41,7 @@ class Meta:
                         "data_type": "string",
                         "instructions": f"Populate label_{x} properly",
                         "accepted_values": ["a", "b", "c"],
-                        "missing_values": "Unknown, Not Reported",
+                        "missing_values": ["a", "b", "c"],
                     }
                     for x in range(2)
                 ]

creator/data_templates/models.py

@@ -210,7 +210,7 @@ def field_definitions_dataframe(self):
         This will become the content of the field definitions file when
         the user requests to download the template files
         """
-        def format_accepted(value):
+        def format_list(value):
             """
             Convert list to delimited str
             """
@@ -224,7 +224,10 @@ def format_accepted(value):
         if "key" in df.columns:
             df.drop(columns=["key"], axis=1, inplace=True)
         df["accepted_values"] = df["accepted_values"].apply(
-            format_accepted
+            format_list
+        )
+        df["missing_values"] = df["missing_values"].apply(
+            format_list
         )
         df.columns = [
             " ".join([w.title() for w in col.split("_")])

tests/data_templates/test_template_models.py

@@ -63,6 +63,7 @@ def test_field_definitions_dataframe(db):
     )
     assert df.shape == (2, len(FieldDefinitionsSchema.key_order) - 1)
     assert set(df["Accepted Values"].values.tolist()) == {"a,b,c"}
+    assert set(df["Missing Values"].values.tolist()) == {"a,b,c"}
 
 
 def test_load_field_definitions(db, tmpdir):