Skip to content

Commit

Permalink
fix: manifest version not being updated (#25)
Browse files Browse the repository at this point in the history
* fix: update manifest to correct extension version

* build: script correctly updates manifest version to extension version

* ci: change release workflow to build and package after release is published
  • Loading branch information
kieranroneill authored Nov 21, 2023
1 parent a6518d7 commit debbc7e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 88 deletions.
89 changes: 4 additions & 85 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,87 +20,23 @@ jobs:
- name: "🔧 Setup"
uses: ./.github/actions/use-dependencies

##
# package
##

build_chrome:
name: "Build Chrome"
needs: install
runs-on: ubuntu-latest
steps:
- name: "🛎 Checkout"
uses: actions/checkout@v3
- name: "🔧 Setup"
uses: ./.github/actions/use-dependencies
- name: "📝 Create .env file"
uses: ./.github/actions/create-env-file
with:
walletconnect_project_id: ${{ secrets.PRODUCTION_WALLETCONNECT_PROJECT_ID }}
- name: "🏗️ Build"
run: yarn build:chrome
- name: "🗜️ Zip build"
run: zip -qr chrome_build.zip .chrome_build/
- name: "📤 Upload build"
uses: actions/upload-artifact@v3
with:
name: chrome_build
path: chrome_build.zip

build_firefox:
name: "Build Firefox"
needs: install
runs-on: ubuntu-latest
steps:
- name: "🛎 Checkout"
uses: actions/checkout@v3
- name: "🔧 Setup"
uses: ./.github/actions/use-dependencies
- name: "📝 Create .env file"
uses: ./.github/actions/create-env-file
with:
walletconnect_project_id: ${{ secrets.PRODUCTION_WALLETCONNECT_PROJECT_ID }}
- name: "🏗️ Build"
run: yarn build:firefox
- name: "🗜️ Zip build"
run: zip -qr firefox_build.zip .firefox_build/
- name: "📤 Upload build"
uses: actions/upload-artifact@v3
with:
name: firefox_build
path: firefox_build.zip

##
# release
##

release:
name: "Release"
needs: [install, build_chrome, build_firefox]
needs: [install]
runs-on: ubuntu-latest
steps:
- name: "🛎 Checkout"
uses: actions/checkout@v3
- name: "🔧 Setup"
uses: ./.github/actions/use-dependencies
# download & package chrome build
- name: "📥 Download Chrome build"
uses: actions/download-artifact@v3
with:
name: chrome_build
- name: "🗜️ Unzip Chrome build"
run: unzip -q chrome_build.zip
- name: "📦 Package Chrome build"
run: yarn package:chrome
# download & package firefox build
- name: "📥 Download Firefox build"
uses: actions/download-artifact@v3
- name: "📝 Create .env file"
uses: ./.github/actions/create-env-file
with:
name: firefox_build
- name: "🗜️ Unzip Firefox build"
run: unzip -q firefox_build.zip
- name: "📦 Package Firefox build"
run: yarn package:firefox
walletconnect_project_id: ${{ secrets.PRODUCTION_WALLETCONNECT_PROJECT_ID }}
- name: "🔖 Release"
env:
# appears on the release commits
Expand All @@ -111,20 +47,3 @@ jobs:
# used to push the release commit and create the tags
GITHUB_TOKEN: ${{ secrets.WRITE_REPOS_TOKEN }}
run: yarn semantic-release

##
# clean up
##

clean_up:
name: "Clean Up"
needs: release
runs-on: ubuntu-latest
steps:
- name: "🗑️ Delete artifacts"
uses: geekyeggo/delete-artifact@v2
with:
failOnError: false
name: |
chrome_build
firefox_build
3 changes: 2 additions & 1 deletion .releaserc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
[
"@semantic-release/exec",
{
"prepareCmd": "./bin/update_manifest_version.sh ${nextRelease.version}"
"prepareCmd": "./bin/update_manifest_version.sh ${nextRelease.version}",
"publishCmd": "yarn concurrently \"yarn build:chrome && yarn package:chrome\" \"yarn build:firefox && yarn package:firefox\""
}
],
[
Expand Down
2 changes: 1 addition & 1 deletion bin/update_manifest_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function main {
fi

printf "%b updating manifest.common.json#version to version '%s' \n" "${INFO_PREFIX}" "${1}"
cat <<< $(jq --arg version "${1}" '.version = $version' src/manifest.common.json) > manifest.common.json
cat <<< $(jq --arg version "${1}" '.version = $version' "${PWD}/src/manifest.common.json") > "${PWD}/src/manifest.common.json"

exit 0
}
Expand Down
2 changes: 1 addition & 1 deletion src/manifest.common.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Kibisis",
"version": "1.2.0",
"version": "1.3.0",
"description": "An AVM wallet in your browser that goes beyond just DeFi.",
"author": "Agora Labs",
"icons": {
Expand Down

0 comments on commit debbc7e

Please sign in to comment.