[hack-scripts] Add waiting for bookinfo app before the traffic genera… #7544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
requested changes
Jul 17, 2024
Comment on lines
+433
to
+440
| # # Do not create traffic generator until all pods are ready | ||
| echo "Waiting till all pods are ready before installing the traffic generator" | ||
| $CLIENT_EXE -n ${NAMESPACE} wait --for condition=Available deployment/details-v1 --timeout=5m | ||
| $CLIENT_EXE -n ${NAMESPACE} wait --for condition=Available deployment/productpage-v1 --timeout=5m | ||
| $CLIENT_EXE -n ${NAMESPACE} wait --for condition=Available deployment/ratings-v1 --timeout=5m | ||
| $CLIENT_EXE -n ${NAMESPACE} wait --for condition=Available deployment/reviews-v1 --timeout=5m | ||
| $CLIENT_EXE -n ${NAMESPACE} wait --for condition=Available deployment/reviews-v2 --timeout=5m | ||
| $CLIENT_EXE -n ${NAMESPACE} wait --for condition=Available deployment/reviews-v3 --timeout=5m |
There was a problem hiding this comment.
There is already a -wt option - see if you can utilize that. It sets WAIT_TIMEOUT env var.
Sometimes we don't want this script waiting (locally, I often do not, I just want the script to end and I'm ok with traffic gen getting some errors). So we don't want this always blocking. But utilize the -wt option if you want to wait. See https://github.com/kiali/kiali/pull/7544/files#diff-7bca579da46f87d5c671523bb79d7146eee8f84e94114d8fa4aeeacb520c126aR119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
The traffic generator is installed right after bookinfo app, however, it doesn't wait till bookinfo app is ready. So, if it takes longer (e.g. cluster is still pulling the images), the traffic generator starts sending requests to the app that is not ready. So results in the traffic generator contain 503 errors