Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor large blob of code that converts yaml from snake case to camel case #551

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

jmazzitelli
Copy link
Contributor

extract to a separate file to make it easier to maintain

This code was originally done as part of PR #524 but we might not merge that, and because I didn't want to lose this refactoring, I am putting it in as this separate PR.

…el case

extract to a separate file to make it easier to maintain
@jmazzitelli jmazzitelli self-assigned this Jul 11, 2022
@jmazzitelli
Copy link
Contributor Author

This is enough to test this works. I ran it and all is OK:
make -e MINIKUBE_PROFILE=ci -e CLUSTER_TYPE=minikube -e MOLECULE_SCENARIO="default affinity-tolerations-resources-test config-values-test" -e MOLECULE_USE_DEV_IMAGES="true" cluster-push molecule-test

I also ran make run-operator-playbook and saw things run through the new task file. So all is good.

Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmazzitelli jmazzitelli merged commit 9788e53 into kiali:master Jul 11, 2022
@jmazzitelli jmazzitelli deleted the refactor-snakecase branch July 11, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants