Hopscotch Hashing [Ready] #128
Conversation
|
Выполнили: |
|
Основан на #106 |
AndreyFdrv
changed the title
…ped-map-hopscotch
Underlying algorithm.The underlying algorithm that you use in your implementation is the inferior, fixed-sized neighbourhood version. Someone else submitted the same algorithm a while back (you linked it at the top, #106 ) and it was equally bad. The superior algorithm can be found here in the appendix. Here is an example implementation by the original authors. This would be a much better basis for a Hopscotch Hashing submission. Implementation.Your implementation is again VERY similar to the one submitted previously and just as strange. Someone clearly stole this code without proper reference from here. I called out the original submission in #106 and I'm calling you out again. This is the second time someone has tried to pass of this code as their own, or at least without proper citation. It's getting quite annoying. |
|
According to jenkins there is a problem with build |
|
I checked build on Windows 10 and Linux Ubuntu 16.04 LTS and build was successfull in both cases. |
|
I see that problem caused by renaming file from "map_insdel_string_feldman_hashset.cpp" to "map_insdel_string_feldman_hashmap.cpp" in test\stress\map\insdel_string folder |
|
I thought that filename is wrong because this file is located in map folder but have "hashset" in the name. So I changed the name. |
|
I will fix CMakeLists.txt |
|
I fixed problem with build |
|
According to the repository rules in README all pull requests should be prepared for "integration" branch, not "master" |
No description provided.