Added open generic support for decorator func #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
requested changes
Jun 6, 2019
| @@ -261,6 +276,27 @@ bool TryDecorate(Type[] typeArguments) | |||
| return arguments.Aggregate(true, (result, args) => result && TryDecorate(args)); | |||
| } | |||
|
|
|||
| private static bool TryDecorateOpenGeneric(this IServiceCollection services, Type serviceType, Func<object, IServiceProvider, object> decorator) | |||
There was a problem hiding this comment.
Hmm... I'm not a big fan of the duplication here. I just merge #76, which made a change to the argument filter below:
- .Where(descriptor => descriptor.ServiceType.IsAssignableTo(serviceType))
+ .Where(descriptor => IsSameGenericType(descriptor.ServiceType, serviceType))Ideally, this should be changed here as well. Are you able to find a way to share more of this code?
There was a problem hiding this comment.
Removed duplication by refining existed TryDecorateOpenGeneric method.
Take a look, please.
There was a problem hiding this comment.
Refactored my implementation, simplified TryDecorateOpenGeneric.
Should look good now.
P.S. locally I have successful build, but AppVeyor fails with "unable to access 'https://github.com/khellang/Scrutor.git/': Could not resolve host: github.com"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kristian!
I have added support for decorating open generic type by decorator func.
This change allows me to initialize component after being resolved by ServiceProvider.
I added test
CanDecorateOpenGenericTypeBasedOnInterfaceByDecoratorFuncthat may clarify my intensions.It would be great if this could be added to your library. Thank you!