Apply button styles to file selector button #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khang-nd
requested changes
Dec 26, 2024
| @@ -1,5 +1,6 @@ | |||
| button, | |||
| [role="button"] { | |||
| [role="button"], | |||
| input[type="file"]::file-selector-button { | |||
There was a problem hiding this comment.
This causes a regression to the existing buttons, from the preview deployment, you can see all buttons are no longer interactive when hovered, clicked etc.
I have played around with this a little bit and here are some discoveries:
- As a pseudo-element itself,
::file-selector-buttoncannot nest other pseudo-elements like::beforeor::after, nor can it work like a normal button element. - There are also no
:disabledor:focuspseudo-classes, only:hover
Given, I'd suggest separating the file selector button to avoid giving the postcss-nested plugin grief and facing unexpected errors during build.
We may consider installing this postcss-extend-rule plugin to reuse the applicable styles from the normal button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR applies the existing button styles to the file selector button and adds a documentation section about that:
The
::file-selector-buttonselector is supported by all major browsers.Thanks