fix: Fix the critical SonarQube failures: close the Scanner after usage.

kghackers · Nov 6, 2024 · cb349f3 · cb349f3
1 parent 37660cc
commit cb349f3
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/kgstatsSrv/src/main/java/ru/klavogonki/statistics/download/PlayerDataDownloader.java b/kgstatsSrv/src/main/java/ru/klavogonki/statistics/download/PlayerDataDownloader.java
@@ -162,13 +162,16 @@ private static String loadUrlToString(final String urlString) throws IOException
 
         // todo: use some nice library instead
         URL url = new URL(urlString);
-        String out = new Scanner(url.openStream(), StandardCharsets.UTF_8) // this line will require java 10
-            .useDelimiter("\\A")
-            .next();
 
-        logger.debug("Response for url {}:", urlString);
-        logger.debug(StringUtils.abbreviate(out, 100));  // do not spam the whole response to log!
-        return out;
+        try (Scanner scanner = new Scanner(url.openStream(), StandardCharsets.UTF_8)) {
+            String out = scanner // this line will require java 10
+                .useDelimiter("\\A")
+                .next();
+
+            logger.debug("Response for url {}:", urlString);
+            logger.debug(StringUtils.abbreviate(out, 100));  // do not spam the whole response to log!
+            return out;
+        }
     }
 
     static List<ImmutablePair<Integer, Integer>> split(Config config) {