-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shade maven plugin add minimizeJar properties #1053
Update shade maven plugin add minimizeJar properties #1053
Conversation
761de55
to
e3724d9
Compare
benchmark/pom.xml
Outdated
</properties> | ||
</profile> | ||
<profile> | ||
<id>blazemeter</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not utilize Blaze-meter tooling in our Keycloak Benchmark, @lvassa88 can you please elaborate how would this be useful for the folks who do not use the Blaze-meter in their frameworks ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kami619 I try to use the keycloak benchmark jar on blameter to run test in different situation/timezone, but the jar that you generate is bigger for BlazeMeter tool, so I use the minimizeJar to solve the issue and upload the jar generated with this option and I think other guys can have the same problem.
…roperties to reduce the size of the generated jar Signed-off-by: Luca Vassallo <[email protected]>
Signed-off-by: Luca Vassallo <[email protected]>
944c579
to
9a391c1
Compare
Hi @kami619, I have modified the PR to remove the profile and add only the minimizedJar configuration to reduce the sizing of the jar generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this branch locally, and I found that once I packaged the JAR file and used it with the kcb.sh
shell script we provide, I get an error
java.lang.ClassNotFoundException: io.gatling.app.Gatling
This indicates that the minimizeJar
option removes the entry class that we depend on.
Looking at Blazemeter, maybe they require only the scenarios and not the full Scala/Gatling bundle. If you build it locally, there is a file original-keycloak-benchmark-0.15-SNAPSHOT.jar
in the target folder that contains only the scenarios. Maybe that is just enough for what you need for Blazemeter.
Update shade maven plugin add minimizeJar properties to reduce the size of the generated jar
Add the minimizedJar because need to upload the jar into blazmeter but it's support upload with max size 50MB.