Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shade maven plugin add minimizeJar properties #1053

Closed

Conversation

lvassa88
Copy link

Update shade maven plugin add minimizeJar properties to reduce the size of the generated jar
Add the minimizedJar because need to upload the jar into blazmeter but it's support upload with max size 50MB.

@lvassa88 lvassa88 force-pushed the feature/minimize-jar-for-blazemeter branch from 761de55 to e3724d9 Compare November 22, 2024 13:14
</properties>
</profile>
<profile>
<id>blazemeter</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not utilize Blaze-meter tooling in our Keycloak Benchmark, @lvassa88 can you please elaborate how would this be useful for the folks who do not use the Blaze-meter in their frameworks ?

Copy link
Author

@lvassa88 lvassa88 Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kami619 I try to use the keycloak benchmark jar on blameter to run test in different situation/timezone, but the jar that you generate is bigger for BlazeMeter tool, so I use the minimizeJar to solve the issue and upload the jar generated with this option and I think other guys can have the same problem.

Luca Vassallo added 2 commits November 26, 2024 15:40
…roperties to reduce the size of the generated jar

Signed-off-by: Luca Vassallo <[email protected]>
@lvassa88 lvassa88 force-pushed the feature/minimize-jar-for-blazemeter branch from 944c579 to 9a391c1 Compare November 26, 2024 14:40
@lvassa88
Copy link
Author

Hi @kami619, I have modified the PR to remove the profile and add only the minimizedJar configuration to reduce the sizing of the jar generated.

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this branch locally, and I found that once I packaged the JAR file and used it with the kcb.sh shell script we provide, I get an error

java.lang.ClassNotFoundException: io.gatling.app.Gatling

This indicates that the minimizeJar option removes the entry class that we depend on.

Looking at Blazemeter, maybe they require only the scenarios and not the full Scala/Gatling bundle. If you build it locally, there is a file original-keycloak-benchmark-0.15-SNAPSHOT.jar in the target folder that contains only the scenarios. Maybe that is just enough for what you need for Blazemeter.

@lvassa88 lvassa88 closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants