test: Make the ReadRows service in tests more modular (#1462)

[kevkim-codes]

• test: begin to refactor the mock service (test: begin to refactor the mock service googleapis/nodejs-bigtable#1447)

• Use prettyPrintRequest from readRowsImpl1

• Define interfaces for creating a Bigtable service

• Remove keyFrom and keyTo from each test

• Define the service inline for standard keys errors

• Add a comment about the refactor steps I am doing

• Add a header to the service parameters file

• Use the ChunkGeneratorParameters interface

• Simplify the diff by creating local variables

• Remove comment

• Eliminate chunks per response constant

• Change imports

• Replace with as ServerImplementationInterface

• Update test/readrows.ts

• Add a second test for an error at a random pos

• Add some comments for documentation

• Chunk generation - add the parameter

• Added comments to all the interfaces

• Fix a regression bug from the merge

---

• test: Eliminate the second ReadRows Service and use a generalized version of the first ReadRows (test: Eliminate the second ReadRows Service and use a generalized version of the first ReadRows googleapis/nodejs-bigtable#1457)

• Use prettyPrintRequest from readRowsImpl1

• Define interfaces for creating a Bigtable service

• Remove keyFrom and keyTo from each test

• Define the service inline for standard keys errors

• Add a comment about the refactor steps I am doing

• Add a header to the service parameters file

• Use the ChunkGeneratorParameters interface

• Simplify the diff by creating local variables

• Remove comment

• Eliminate chunks per response constant

• Change imports

• Set up the second ReadRows service to use params

• Remove duplicate copy of generate chunks from serv

• Remove second copy of isKeyInRowSet

• Eliminate duplicate copies of the debug log

• Fix a bug for the to and from service parameters

Only ignore keyFrom and keyTo when they are undefined and not just when they are Falsy.

• Add cancel back into the mock service for testing

• Add variables to match service 1

• Add one more check to match the other service

• Remove usages of ReadRows2Impl

• Remove the new service

The old service has been generalized enough to mock correct server behaviour.

• Moved the position of the comment for 150 rows

• Eliminate setting keyTo and keyFrom

they are undefined anyway.

• Add a second test for an error at a random pos

• Add some comments for documentation

• Chunk generation - add the parameter

• Added comments to all the interfaces

• Delete file

• Change splitted to split

• Remove export

• Don’t rename the interfaces

There is no point

• Increase Windows timeout

• Provide functions to eliminate if statements

• Eliminate the if statements

Make a direct call to generateChunksFromRequest

• Revert "Eliminate the if statements"

This reverts commit 0996e89.

• Revert "Provide functions to eliminate if statements"

This reverts commit 4a4761f.

• Change any’s to string | undefined

• Eliminate duplicate code for setting timeouts

• remove only

• Update test/readrows.ts

• Update test/readrows.ts

• Update test/readrows.ts

• Update test/readrows.ts

• Update test/readrows.ts

• Update test/readrows.ts

• Update test/readrows.ts

---

• test: Eliminate repeated if statements in the ReadRows mock service reducing the size of it significantly (test: Eliminate repeated if statements in the ReadRows mock service reducing the size of it significantly googleapis/nodejs-bigtable#1460)

• Use prettyPrintRequest from readRowsImpl1

• Define interfaces for creating a Bigtable service

• Remove keyFrom and keyTo from each test

• Define the service inline for standard keys errors

• Add a comment about the refactor steps I am doing

• Add a header to the service parameters file

• Use the ChunkGeneratorParameters interface

• Simplify the diff by creating local variables

• Remove comment

• Eliminate chunks per response constant

• Change imports

• Set up the second ReadRows service to use params

• Remove duplicate copy of generate chunks from serv

• Remove second copy of isKeyInRowSet

• Eliminate duplicate copies of the debug log

• Fix a bug for the to and from service parameters

Only ignore keyFrom and keyTo when they are undefined and not just when they are Falsy.

• Add cancel back into the mock service for testing

• Add variables to match service 1

• Add one more check to match the other service

• Remove usages of ReadRows2Impl

• Remove the new service

The old service has been generalized enough to mock correct server behaviour.

• Moved the position of the comment for 150 rows

• Eliminate setting keyTo and keyFrom

they are undefined anyway.

• Add a second test for an error at a random pos

• Add some comments for documentation

• Chunk generation - add the parameter

• Added comments to all the interfaces

• Group the property getter into a function

• Group key selection into functions

• Fix typo: default key

• Documentation for isInRowSet

• Eliminate variable - move function inline

• Omit optional selector on stream

• Create ReadRowsWritableStream interface

• Use new interface, remove ServerWritableStream

• Don’t pass the whole stream into helpers

• Add a function for generating the chunks

• The debug log should be a pass through parameter

• Solve compiler errors resulting immediately from

merge

• Add debugLog parameter to various functions

• Add return type

• Remove exports - functions are only used in this

module

• Revise merge correction

• Remove TODO for the stream type

• Update the getKeyValue function

• Eliminate place where debug log is needed

• Run linter

• test: Break the ReadRows service down into classes instead of a single long function (test: Break the ReadRows service down into classes instead of a single long function googleapis/nodejs-bigtable#1461)

• Use prettyPrintRequest from readRowsImpl1

• Define interfaces for creating a Bigtable service

• Remove keyFrom and keyTo from each test

• Define the service inline for standard keys errors

• Add a comment about the refactor steps I am doing

• Add a header to the service parameters file

• Use the ChunkGeneratorParameters interface

• Simplify the diff by creating local variables

• Remove comment

• Eliminate chunks per response constant

• Change imports

• Set up the second ReadRows service to use params

• Remove duplicate copy of generate chunks from serv

• Remove second copy of isKeyInRowSet

• Eliminate duplicate copies of the debug log

• Fix a bug for the to and from service parameters

Only ignore keyFrom and keyTo when they are undefined and not just when they are Falsy.

• Add cancel back into the mock service for testing

• Add variables to match service 1

• Add one more check to match the other service

• Remove usages of ReadRows2Impl

• Remove the new service

The old service has been generalized enough to mock correct server behaviour.

• Moved the position of the comment for 150 rows

• Eliminate setting keyTo and keyFrom

they are undefined anyway.

• Add a second test for an error at a random pos

• Add some comments for documentation

• Chunk generation - add the parameter

• Added comments to all the interfaces

• Group the property getter into a function

• Group key selection into functions

• Fix typo: default key

• Documentation for isInRowSet

• Eliminate variable - move function inline

• Omit optional selector on stream

• Create ReadRowsWritableStream interface

• Use new interface, remove ServerWritableStream

• Don’t pass the whole stream into helpers

• Add a function for generating the chunks

• The debug log should be a pass through parameter

• Add some TODOs about how to address this next

• Pull send response into a class

• Create a dedicated class for defining the service

• Change name to readRowsRequestHandler

• Pull the function that generates the chunks into

Separate module

• Generate documentation

• Add more documentation to the Service class

• Add debugLog as a method parameter

• Solve compiler errors resulting immediately from

merge

• Add debugLog parameter to various functions

• Add return type

• Remove exports - functions are only used in this

module

• Revise merge correction

• Remove TODO for the stream type

• Update the getKeyValue function

• Eliminate place where debug log is needed

• Run linter

• Eliminate the function that creates a service

Add a factory method instead

• Add documentation for the constructor

• Remove the TODO

• Set the timeout for the test

• Increase the timeout

• Eliminate ternary statement

• 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

• Add a couple of comments

• re-write the ternary expression

---

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕