Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Stylelint 16 Output #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Phillita
Copy link

Motivation

Updating to Stylelint version 16 + returns an empty output for valid warnings

Changes

  • Move the linter to another class
  • Handle thread exit codes in order to parse the output correctly
  • Parse the stderr output for linter warnings
  • Add specs

Other

This will contain the changes for the new configuration as well.
This can merge both or the config changes can be merged before this one.
See #15

Phillita added 5 commits June 25, 2024 10:02
Added a new config class. Handle new config from the pronto.yml. Added warning when using the old config. More Rubocop warnings fixed. Added some quality of life improvements to the specs.
Remove constants that only the config needs. Move config to attr_reader
Remove deprecated code in favour of the new config. Updated the readme. Fixed specs.
Extract patch linter runs to a new service. Parse thread exit codes to handle error cases. Use stderr for some warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant