Add provisional stdlib venv support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modifies the way the bash activate script is handled to work with both virtualenv and the python3 bundled venv. The venv version had a recent change for windows support that caused it to diverge from how virtualenv solved the same cygwin related problems. So there are now two totally different bash activation scripts depending on which tool you use. The venv style puts the literal path text in several location whereas every other script in both venv and virtualenv puts the literal text only once in a variable and then references the variable. To change multiple path strings I had to rewrite the path replacement mechanism for bash to bulk rewrite every line that contains the path rather than a targeted line replacement like before. I'm not sure how much more venv will diverge from virtualenv in the future but this should enable it to work for now.
Closed
mattthhh
approved these changes
Jun 14, 2024
|
Thanks for the code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the way the bash activate script is handled to work with both virtualenv and the python3 bundled venv. The venv version had a recent change for windows support that caused it to diverge from how virtualenv solved the same cygwin related problems. So there are now two totally different bash activation scripts depending on which tool you use.
The venv style puts the literal path text in several location whereas every other script in both venv and virtualenv puts the literal text only once in a variable and then references the variable. To change multiple path strings I had to rewrite the path replacement mechanism for bash to bulk rewrite every line that contains the path rather than a targeted line replacement like before.
I'm not sure how much more venv will diverge from virtualenv in the future but this should enable it to work for now.