Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use cookies instead of headers #14

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

artoonie
Copy link

@artoonie artoonie commented Feb 2, 2024

It seems that nyt-s is now a cookie (and capitalized), not a header.

I don't know if this is universally rolled out, but the previous code doesn't work for my account, and this does. I assume this will work for everyone, but please do verify it still works for you.

Commit 1: The primary bugfix
Commit 2: Little changes to the plotly file to dynamically select a split year, to handle a 0 as the ceiling (which is what argparse provides on my machine I think), and to handle no data before the split year

plot/plot.py Outdated Show resolved Hide resolved
Copy link
Owner

@kesyog kesyog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the find and the fix! It generally looks good to me, but I had some minor feedback.

plot/plot.py Outdated Show resolved Hide resolved
src/api_client.rs Show resolved Hide resolved
@kesyog
Copy link
Owner

kesyog commented Feb 5, 2024

lgtm. thanks again!

@kesyog kesyog merged commit b63c902 into kesyog:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants