src/test_report: optimize TestReport._get_report method

As the API design has been involved over time, we have eliminated `incomplete` from the set of possible values for `Node.result` field. Optimize method to get reports accordingly. Also, remove the unnecessary parenthesis from a line. Signed-off-by: Jeny Sadadia <[email protected]>
kernelci · Aug 9, 2023 · ee92c8b · ee92c8b
1 parent 1fba31b
commit ee92c8b
Showing 1 changed file with 8 additions and 16 deletions.
diff --git a/src/test_report.py b/src/test_report.py
@@ -89,23 +89,15 @@ def _get_report(self, root_node):
                         )
         template = template_env.get_template("test-report.jinja2")
         revision = root_node['revision']
-        if root_node['result'] == 'incomplete':
-            subject = (f"\
+        results = self._get_results_data(root_node)
+        stats = results['stats']
+        groups = results['groups']
+        subject = f"\
 [STAGING] {revision['tree']}/{revision['branch']} {revision['describe']}: \
-Failed to create source tarball for {root_node['name']}")
-            content = template.render(
-                subject=subject, root=root_node, groups={}
-            )
-        else:
-            results = self._get_results_data(root_node)
-            stats = results['stats']
-            groups = results['groups']
-            subject = (f"\
-[STAGING] {revision['tree']}/{revision['branch']} {revision['describe']}: \
-{stats['total']} runs {stats['failures']} failures")
-            content = template.render(
-                subject=subject, root=root_node, groups=groups
-            )
+{stats['total']} runs {stats['failures']} failures"
+        content = template.render(
+            subject=subject, root=root_node, groups=groups
+        )
         return content, subject
 
     def _send_report(self, subject, content):