fluster-on-chromeos: Simplify ssh between client and dut #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify `ssh` connection between client and DUT by setting the `/root/.ssh/config` to avoid using `-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /home/cros/.ssh/id_rsa` flags on every connection. Keeps only the first `ssh` connection flags which waits until the DUT to be available. Signed-off-by: Denis Yuji Shimizu <[email protected]>
denisyuji
force-pushed
the
simplify-ssh
branch
from
c65a3ce
to
61964ea
Compare
|
Is there any job example where it is tested? |
|
ping |
|
Hi @nuclearcat , sorry, lost this one. Sure! See: https://lava.collabora.dev/scheduler/job/16552488 |
|
Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic change - Simplify
sshconnection between client and DUT by setting the/root/.ssh/configto avoid using-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /home/cros/.ssh/id_rsaflags on every connection to improve code readability.Keeps only the first
sshconnection flags which waits until the DUT to be available.