Get last modified from data #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're not going to be loading data in KCIDB directly from the submission queue, remove the rate throttling (which was inactive anyway due to particular database drivers being used).
Instead solely targeting the get_last_modified() method to databases which have load rate limit, make all of them support it, and return the maximum `_timestamp` value across all tables, if the schema has it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're not going to be loading data in KCIDB directly from the submission queue, remove the rate throttling (which was inactive anyway due to particular database drivers being used).
Instead solely targeting the get_last_modified() method to databases which have load rate limit, make all of them support it, and return the maximum
_timestampvalue across all tables, if the schema has it.Concerns #541