Add hardware details filters #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francisco2002
force-pushed
the
feat/hardware-details-filters
branch
from
2748285
to
accb03a
Compare
WilsonNet
reviewed
Nov 22, 2024
| return zFilterNumberKeys.safeParse(key).success; | ||
| }; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
add TODO to remove this
There was a problem hiding this comment.
just change the declartion to a type
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |
| type requestFilters = { |
There was a problem hiding this comment.
I use const targetFilter: readonly string[] = requestFilters[target]; in a function below. Change for type give a error in typescript
There was a problem hiding this comment.
If you are using it you don't need the eslint-disable
|
|
||
| import FilterLink from '../../HardwareDetailsFilterLink'; | ||
|
|
||
| //import { useDiffFilterParams } from '../../hardwareDetailsUtils'; |
|
Create a TODO to remind us to review the need for those file duplications |
WilsonNet
approved these changes
Nov 22, 2024
lfjnascimento
approved these changes
Nov 22, 2024
Francisco2002
force-pushed
the
feat/hardware-details-filters
branch
from
accb03a
to
18424d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I add the filters in hardware details in frontend and add counts in hardware tabs.
Close #572