Feat/hardware by trees checkout #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the order_by field in HardwareDetails view to use "-build__checkout__start_time" instead of "-start_time" for more accurate ordering of results.
WilsonNet
force-pushed
the
feat/hardware-by-trees-checkout
branch
from
cafae56
to
7193edf
Compare
|
front-end is making two requests, one |
WilsonNet
force-pushed
the
feat/hardware-by-trees-checkout
branch
from
e8c6903
to
df2aa1d
Compare
Refactored HardwareView to consolidate __getSlowResult and __getFastResult methods into a single _getResults method. Updated the order_by field in checkouts_subquery to use "-start_time" for more accurate ordering that considerates the head of the branch Also fix the logic for calculating builds to account for the array of hardwares Closes #530
WilsonNet
force-pushed
the
feat/hardware-by-trees-checkout
branch
from
df2aa1d
to
c19fb9f
Compare
Francisco2002
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the hardware listing accounts for heads of the trees only
This also fix the logic to account for builds
How to test
Go to the hardware listing page
Enter in any of the hardware the details and see how the count is more precise
Note: It is not exactly precise, if this does not get solved in time another ticket will be created